From 019474fdd0c0fb5ba44b07d7fe9dbd7d20a35d85 Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha <ahmed.bougacha@gmail.com> Date: Wed, 6 May 2015 02:08:27 +0000 Subject: [PATCH] Revert "[analyzer] scan-build: support spaces in compiler path and arguments." This reverts commit r236423 and its followup r236533, as indiscriminate quoting makes for too much quoting (and clang doesn't like both '"-c"' and -D"FOO=bar"). git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@236562 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/scan-build/ccc-analyzer | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/scan-build/ccc-analyzer b/tools/scan-build/ccc-analyzer index 8e12126e793..4549b29a806 100755 --- a/tools/scan-build/ccc-analyzer +++ b/tools/scan-build/ccc-analyzer @@ -145,7 +145,7 @@ sub ProcessClangFailure { print OUT "@$Args\n"; close OUT; `uname -a >> $PPFile.info.txt 2>&1`; - `"$Compiler" -v >> $PPFile.info.txt 2>&1`; + `$Compiler -v >> $PPFile.info.txt 2>&1`; rename($ofile, "$PPFile.stderr.txt"); return (basename $PPFile); } @@ -180,10 +180,6 @@ sub GetCCArgs { # Strip leading and trailing whitespace characters. $line =~ s/^\s+|\s+$//g; my @items = quotewords('\s+', 0, $line); - # Wrap arguments that have spaces with quotes. - foreach (@items) { - $_ = qq/"$_"/ if (/\s+/); - } my $cmd = shift @items; die "cannot find 'clang' in 'clang' command\n" if (!($cmd =~ /clang/)); return \@items; -- GitLab