diff --git a/lib/CodeGen/CodeGenFunction.cpp b/lib/CodeGen/CodeGenFunction.cpp index f0a5c64d2fdfeb0baa13f9b8f781d6c81a9d730d..5db441197e1f3a30e9401149dd233b6d570ab3e8 100644 --- a/lib/CodeGen/CodeGenFunction.cpp +++ b/lib/CodeGen/CodeGenFunction.cpp @@ -431,7 +431,11 @@ void CodeGenFunction::EmitBranchOnBoolExpr(const Expr *Cond, EmitBranchOnBoolExpr(CondBOp->getLHS(), LHSTrue, FalseBlock); EmitBlock(LHSTrue); + // Any temporaries created here are conditional. + StartConditionalBranch(); EmitBranchOnBoolExpr(CondBOp->getRHS(), TrueBlock, FalseBlock); + FinishConditionalBranch(); + return; } else if (CondBOp->getOpcode() == BinaryOperator::LOr) { // If we have "0 || X", simplify the code. "1 || X" would have constant @@ -454,7 +458,11 @@ void CodeGenFunction::EmitBranchOnBoolExpr(const Expr *Cond, EmitBranchOnBoolExpr(CondBOp->getLHS(), TrueBlock, LHSFalse); EmitBlock(LHSFalse); + // Any temporaries created here are conditional. + StartConditionalBranch(); EmitBranchOnBoolExpr(CondBOp->getRHS(), TrueBlock, FalseBlock); + FinishConditionalBranch(); + return; } } diff --git a/lib/CodeGen/CodeGenFunction.h b/lib/CodeGen/CodeGenFunction.h index 30ad663771be78ba5e5230ebfed7cefeb86ddc67..684d1ce2859930d6d43ca81db525fae3967cec35 100644 --- a/lib/CodeGen/CodeGenFunction.h +++ b/lib/CodeGen/CodeGenFunction.h @@ -283,6 +283,9 @@ public: /// FinishConditionalBranch - Should be called after a conditional part of an /// expression has been emitted. void FinishConditionalBranch() { + assert(ConditionalBranchLevel != 0 && + "Conditional branch mismatch!"); + --ConditionalBranchLevel; } diff --git a/test/CodeGenCXX/temp-order.cpp b/test/CodeGenCXX/temp-order.cpp index 05a9aed2defa41f458c2fa23483e892ee8a1ec88..341cd0ca134a01a1d6a85f05e54c2b4a123729d4 100644 --- a/test/CodeGenCXX/temp-order.cpp +++ b/test/CodeGenCXX/temp-order.cpp @@ -129,10 +129,30 @@ static unsigned f6() { return tt.Product; } +// 5, 2 +static unsigned f7() { + TempTracker tt; + { + (void)((A(tt, 2, false) && A(tt, 3, false)) || A(tt, 5, false)); + } + return tt.Product; +} + +// 5, 2 +static unsigned f8() { + TempTracker tt; + + { + (void)((A(tt, 2) || A(tt, 3)) && A(tt, 5)); + } + return tt.Product; +} + extern "C" void error(); extern "C" void print(const char *Name, unsigned N); -#define ORDER3(a, b, c) (pow(a, 1) * pow(b, 2) * pow(c, 3)) +#define ORDER2(a, b) (pow(a, 1) * pow(b, 2)) +#define ORDER3(a, b, c) (ORDER2(a, b) * pow(c, 3)) #define ORDER4(a, b, c, d) (ORDER3(a, b, c) * pow(d, 4)) #define ORDER5(a, b, c, d, e) (ORDER4(a, b, c, d) * pow(e, 5)) #define ORDER6(a, b, c, d, e, f) (ORDER5(a, b, c, d, e) * pow(f, 6)) @@ -171,6 +191,16 @@ void test() { print("f6", f6()); if (f6() != ORDER6(3, 7, 11, 5, 13, 2)) error(); + +// CHECK: call void @print(i8* {{.*}}, i32 20) + print("f7", f7()); + if (f7() != ORDER2(5, 2)) + error(); + +// CHECK: call void @print(i8* {{.*}}, i32 20) + print("f8", f8()); + if (f8() != ORDER2(5, 2)) + error(); }