diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td index 18b2bc218710c2931e4815613c65e59022316890..c41e19dbe4f89e8508bac4562ac09c7ed10ff6d4 100644 --- a/include/clang/Basic/DiagnosticSemaKinds.td +++ b/include/clang/Basic/DiagnosticSemaKinds.td @@ -6417,12 +6417,12 @@ def warn_non_virtual_dtor : Warning< def warn_delete_non_virtual_dtor : Warning< "%select{delete|destructor}0 called on non-final %1 that has " "virtual functions but non-virtual destructor">, - InGroup<DeleteNonVirtualDtor>, DefaultIgnore; + InGroup<DeleteNonVirtualDtor>, DefaultIgnore, ShowInSystemHeader; def note_delete_non_virtual : Note< "qualify call to silence this warning">; def warn_delete_abstract_non_virtual_dtor : Warning< "%select{delete|destructor}0 called on %1 that is abstract but has " - "non-virtual destructor">, InGroup<DeleteNonVirtualDtor>; + "non-virtual destructor">, InGroup<DeleteNonVirtualDtor>, ShowInSystemHeader; def warn_overloaded_virtual : Warning< "%q0 hides overloaded virtual %select{function|functions}1">, InGroup<OverloadedVirtual>, DefaultIgnore; diff --git a/lib/Sema/SemaExprCXX.cpp b/lib/Sema/SemaExprCXX.cpp index 456aff2fe00ed827bd4e1116ee92c63afaa6133f..8de3d33d085e7904000355e1a86a63fdc83ab0a9 100644 --- a/lib/Sema/SemaExprCXX.cpp +++ b/lib/Sema/SemaExprCXX.cpp @@ -3284,7 +3284,7 @@ void Sema::CheckVirtualDtorCall(CXXDestructorDecl *dtor, SourceLocation Loc, bool IsDelete, bool CallCanBeVirtual, bool WarnOnNonAbstractTypes, SourceLocation DtorLoc) { - if (!dtor || dtor->isVirtual() || !CallCanBeVirtual) + if (!dtor || dtor->isVirtual() || !CallCanBeVirtual || isUnevaluatedContext()) return; // C++ [expr.delete]p3: diff --git a/test/SemaCXX/destructor.cpp b/test/SemaCXX/destructor.cpp index 49cdc50f3c13c7464b77f783ea0738e52b217435..31ee60a718adc42b4e6924ef363051d214d140e0 100644 --- a/test/SemaCXX/destructor.cpp +++ b/test/SemaCXX/destructor.cpp @@ -1,5 +1,31 @@ // RUN: %clang_cc1 -std=c++11 -triple %itanium_abi_triple -fsyntax-only -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -fcxx-exceptions -verify %s // RUN: %clang_cc1 -std=c++11 -triple %ms_abi_triple -DMSABI -fsyntax-only -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -verify %s + +#if defined(BE_THE_HEADER) + +// Wdelete-non-virtual-dtor should warn about the delete from smart pointer +// classes in system headers (std::unique_ptr...) too. + +#pragma clang system_header +namespace dnvd { +template <typename T> +class simple_ptr { +public: + simple_ptr(T* t): _ptr(t) {} + ~simple_ptr() { delete _ptr; } // \ + // expected-warning {{delete called on non-final 'dnvd::B' that has virtual functions but non-virtual destructor}} \ + // expected-warning {{delete called on non-final 'dnvd::D' that has virtual functions but non-virtual destructor}} + T& operator*() const { return *_ptr; } +private: + T* _ptr; +}; +} + +#else + +#define BE_THE_HEADER +#include __FILE__ + class A { public: ~A(); @@ -212,18 +238,6 @@ struct VD: VB {}; struct VF final: VB {}; -template <typename T> -class simple_ptr { -public: - simple_ptr(T* t): _ptr(t) {} - ~simple_ptr() { delete _ptr; } // \ - // expected-warning {{delete called on non-final 'dnvd::B' that has virtual functions but non-virtual destructor}} \ - // expected-warning {{delete called on non-final 'dnvd::D' that has virtual functions but non-virtual destructor}} - T& operator*() const { return *_ptr; } -private: - T* _ptr; -}; - template <typename T> class simple_ptr2 { public: @@ -335,10 +349,28 @@ void warn0() { } } +// Taken from libc++, slightly simplified. +template <class> +struct __is_destructible_apply { typedef int type; }; +struct __two {char __lx[2];}; +template <typename _Tp> +struct __is_destructor_wellformed { + template <typename _Tp1> + static char __test(typename __is_destructible_apply< + decltype(_Tp1().~_Tp1())>::type); + template <typename _Tp1> + static __two __test (...); + + static const bool value = sizeof(__test<_Tp>(12)) == sizeof(char); +}; + void warn0_explicit_dtor(B* b, B& br, D* d) { b->~B(); // expected-warning {{destructor called on non-final 'dnvd::B' that has virtual functions but non-virtual destructor}} expected-note{{qualify call to silence this warning}} b->B::~B(); // No warning when the call isn't virtual. + // No warning in unevaluated contexts. + (void)__is_destructor_wellformed<B>::value; + br.~B(); // expected-warning {{destructor called on non-final 'dnvd::B' that has virtual functions but non-virtual destructor}} expected-note{{qualify call to silence this warning}} br.B::~B(); @@ -451,3 +483,4 @@ void foo1() { x.foo1(); } } +#endif // BE_THE_HEADER diff --git a/test/SemaCXX/implicit-exception-spec.cpp b/test/SemaCXX/implicit-exception-spec.cpp index f400c222de83c7f5ac27c0a7e0bec36633ada8ee..c21f773e94c66d1649a09ec5896e1e2300dccbff 100644 --- a/test/SemaCXX/implicit-exception-spec.cpp +++ b/test/SemaCXX/implicit-exception-spec.cpp @@ -121,7 +121,7 @@ namespace PotentiallyConstructed { T &a = *p; static_assert(noexcept(a = a) == D, ""); static_assert(noexcept(a = static_cast<T&&>(a)) == E, ""); - static_assert(noexcept(delete &a) == F, ""); // expected-warning 2{{abstract}} + static_assert(noexcept(delete &a) == F, ""); // These are last because the first failure here causes instantiation to bail out. static_assert(noexcept(new (nothrow) T()) == A, ""); // expected-error 2{{abstract}}