diff --git a/lib/CodeGen/CGVTables.cpp b/lib/CodeGen/CGVTables.cpp index 3dd7a15fe359314d31a80377f1b966d4fb788ac2..d74226ec89bbbe5e13a22777dea03d866b935a4f 100644 --- a/lib/CodeGen/CGVTables.cpp +++ b/lib/CodeGen/CGVTables.cpp @@ -2723,8 +2723,13 @@ void CodeGenVTables::EmitThunk(GlobalDecl GD, const ThunkInfo &Thunk, return; } - // We should never be able to get a function with a definition here. - assert(false && "Shouldn't have an already existing definition"); + // If a function has a body, it should have available_externally linkage. + assert(ThunkFn->hasAvailableExternallyLinkage() && + "Function should have available_externally linkage!"); + + // Change the linkage. + CGM.setFunctionLinkage(cast<CXXMethodDecl>(GD.getDecl()), ThunkFn); + return; } // Actually generate the thunk body. diff --git a/test/CodeGenCXX/thunks-available-externally.cpp b/test/CodeGenCXX/thunks-available-externally.cpp index 697a00018787dca3210d31ae1f871d8f2d551baf..dfdb786b18ee7b03d1f8432e4b2958675d63a9b9 100644 --- a/test/CodeGenCXX/thunks-available-externally.cpp +++ b/test/CodeGenCXX/thunks-available-externally.cpp @@ -68,3 +68,21 @@ void f() { } } + +// Test that we don't assert. +namespace Test3 { + +struct A { + virtual ~A(); + + int a; +}; + +struct B : A { }; +struct C : virtual B { }; + +void f() { + C c; +} + +}