diff --git a/include/clang/Driver/Job.h b/include/clang/Driver/Job.h index 032e83125141841a55b0bc195502b5c53e942151..2695f9eadbd9b8262a0c3775659c1ebdcf5b8f3b 100644 --- a/include/clang/Driver/Job.h +++ b/include/clang/Driver/Job.h @@ -13,6 +13,7 @@ #include "clang/Basic/LLVM.h" #include "llvm/ADT/SmallVector.h" #include "llvm/Option/Option.h" +#include "llvm/ADT/iterator.h" #include <memory> namespace llvm { @@ -158,8 +159,8 @@ class JobList : public Job { public: typedef SmallVector<std::unique_ptr<Job>, 4> list_type; typedef list_type::size_type size_type; - typedef list_type::iterator iterator; - typedef list_type::const_iterator const_iterator; + typedef llvm::pointee_iterator<list_type::iterator> iterator; + typedef llvm::pointee_iterator<list_type::const_iterator> const_iterator; private: list_type Jobs; diff --git a/lib/Driver/Compilation.cpp b/lib/Driver/Compilation.cpp index 124ecca4d3bc6543fc63612020b21214788c3a03..2bcbd5cf943ce95892253d3a8bcda6dbe22d21e1 100644 --- a/lib/Driver/Compilation.cpp +++ b/lib/Driver/Compilation.cpp @@ -202,9 +202,8 @@ void Compilation::ExecuteJob(const Job &J, FailingCommands.push_back(std::make_pair(Res, FailingCommand)); } else { const JobList *Jobs = cast<JobList>(&J); - for (JobList::const_iterator it = Jobs->begin(), ie = Jobs->end(); - it != ie; ++it) - ExecuteJob(**it, FailingCommands); + for (const auto &Job : *Jobs) + ExecuteJob(Job, FailingCommands); } } diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp index 6cf6c01dcadfb7665ab13d897fc0aaffcfd43107..8b097755064df577da461205d4efc7eda0800852 100644 --- a/lib/Driver/Driver.cpp +++ b/lib/Driver/Driver.cpp @@ -578,8 +578,8 @@ void Driver::generateCompilationDiagnostics(Compilation &C, void Driver::setUpResponseFiles(Compilation &C, Job &J) { if (JobList *Jobs = dyn_cast<JobList>(&J)) { - for (JobList::iterator I = Jobs->begin(), E = Jobs->end(); I != E; ++I) - setUpResponseFiles(C, **I); + for (auto &Job : *Jobs) + setUpResponseFiles(C, Job); return; } diff --git a/lib/Driver/Job.cpp b/lib/Driver/Job.cpp index 1202c997b5e1321af4a6e080ccb8f7925522f1c5..c13b56e1be8132012efde774d6ead4a8337521f5 100644 --- a/lib/Driver/Job.cpp +++ b/lib/Driver/Job.cpp @@ -287,8 +287,8 @@ JobList::JobList() : Job(JobListClass) {} void JobList::Print(raw_ostream &OS, const char *Terminator, bool Quote, bool CrashReport) const { - for (const_iterator it = begin(), ie = end(); it != ie; ++it) - (*it)->Print(OS, Terminator, Quote, CrashReport); + for (const auto &Job : *this) + Job.Print(OS, Terminator, Quote, CrashReport); } void JobList::clear() { Jobs.clear(); } diff --git a/lib/Frontend/CreateInvocationFromCommandLine.cpp b/lib/Frontend/CreateInvocationFromCommandLine.cpp index 24f9adf5ba45fd936c89376dfe9e1cdd758b396d..4a8a8a029e796fccce3c291fd6b983d968f2e926 100644 --- a/lib/Frontend/CreateInvocationFromCommandLine.cpp +++ b/lib/Frontend/CreateInvocationFromCommandLine.cpp @@ -63,7 +63,7 @@ clang::createInvocationFromCommandLine(ArrayRef<const char *> ArgList, // We expect to get back exactly one command job, if we didn't something // failed. const driver::JobList &Jobs = C->getJobs(); - if (Jobs.size() != 1 || !isa<driver::Command>(**Jobs.begin())) { + if (Jobs.size() != 1 || !isa<driver::Command>(*Jobs.begin())) { SmallString<256> Msg; llvm::raw_svector_ostream OS(Msg); Jobs.Print(OS, "; ", true); @@ -71,7 +71,7 @@ clang::createInvocationFromCommandLine(ArrayRef<const char *> ArgList, return nullptr; } - const driver::Command &Cmd = cast<driver::Command>(**Jobs.begin()); + const driver::Command &Cmd = cast<driver::Command>(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { Diags->Report(diag::err_fe_expected_clang_command); return nullptr; diff --git a/lib/Tooling/CompilationDatabase.cpp b/lib/Tooling/CompilationDatabase.cpp index f16f64744e2f23bd9709ed2483aa92ff1654c995..7613988c96d9acee1e500b6204260d3ad65c7365 100644 --- a/lib/Tooling/CompilationDatabase.cpp +++ b/lib/Tooling/CompilationDatabase.cpp @@ -249,10 +249,9 @@ static bool stripPositionalArgs(std::vector<const char *> Args, CompileJobAnalyzer CompileAnalyzer; - for (driver::JobList::const_iterator I = Jobs.begin(), E = Jobs.end(); I != E; - ++I) { - if ((*I)->getKind() == driver::Job::CommandClass) { - const driver::Command &Cmd = cast<driver::Command>(**I); + for (const auto &Job : Jobs) { + if (Job.getKind() == driver::Job::CommandClass) { + const driver::Command &Cmd = cast<driver::Command>(Job); // Collect only for Assemble jobs. If we do all jobs we get duplicates // since Link jobs point to Assemble jobs as inputs. if (Cmd.getSource().getKind() == driver::Action::AssembleJobClass) diff --git a/lib/Tooling/Tooling.cpp b/lib/Tooling/Tooling.cpp index aa72f630ff1a7dc93fa2ef0cd3eecfa8ab4b1bab..7109584f539eb658d9a71b3420bc0358db92d4f0 100644 --- a/lib/Tooling/Tooling.cpp +++ b/lib/Tooling/Tooling.cpp @@ -69,7 +69,7 @@ static const llvm::opt::ArgStringList *getCC1Arguments( // We expect to get back exactly one Command job, if we didn't something // failed. Extract that job from the Compilation. const clang::driver::JobList &Jobs = Compilation->getJobs(); - if (Jobs.size() != 1 || !isa<clang::driver::Command>(**Jobs.begin())) { + if (Jobs.size() != 1 || !isa<clang::driver::Command>(*Jobs.begin())) { SmallString<256> error_msg; llvm::raw_svector_ostream error_stream(error_msg); Jobs.Print(error_stream, "; ", true); @@ -80,7 +80,7 @@ static const llvm::opt::ArgStringList *getCC1Arguments( // The one job we find should be to invoke clang again. const clang::driver::Command &Cmd = - cast<clang::driver::Command>(**Jobs.begin()); + cast<clang::driver::Command>(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { Diagnostics->Report(clang::diag::err_fe_expected_clang_command); return nullptr;