diff --git a/lib/AST/ODRHash.cpp b/lib/AST/ODRHash.cpp index 0e822ce35b8ce19e88f25a10e94eb2b92f4a09ce..bd08de45c6206b10177f47b4560f91ba91abc14b 100644 --- a/lib/AST/ODRHash.cpp +++ b/lib/AST/ODRHash.cpp @@ -128,7 +128,25 @@ void ODRHash::AddTemplateName(TemplateName Name) { } } -void ODRHash::AddTemplateArgument(TemplateArgument TA) {} +void ODRHash::AddTemplateArgument(TemplateArgument TA) { + auto Kind = TA.getKind(); + ID.AddInteger(Kind); + + switch (Kind) { + case TemplateArgument::Null: + case TemplateArgument::Declaration: + case TemplateArgument::NullPtr: + case TemplateArgument::Integral: + case TemplateArgument::Template: + case TemplateArgument::TemplateExpansion: + case TemplateArgument::Expression: + case TemplateArgument::Pack: + break; + case TemplateArgument::Type: + AddQualType(TA.getAsType()); + break; + } +} void ODRHash::AddTemplateParameterList(const TemplateParameterList *TPL) {} void ODRHash::clear() { diff --git a/test/Modules/odr_hash.cpp b/test/Modules/odr_hash.cpp index a6a0b74743aaa315fa03c8cc8df3502abb7e3dac..fb7005be259527331b46af3e50320a4fc7e28fd2 100644 --- a/test/Modules/odr_hash.cpp +++ b/test/Modules/odr_hash.cpp @@ -900,6 +900,24 @@ S2 s2; #endif } +namespace TemplateArgument { +#if defined(FIRST) +template<typename> struct U1 {}; +struct S1 { + U1<int> u; +}; +#elif defined(SECOND) +template<typename> struct U1 {}; +struct S1 { + U1<double> u; +}; +#else +S1 s1; +// expected-error@first.h:* {{'TemplateArgument::S1::u' from module 'FirstModule' is not present in definition of 'TemplateArgument::S1' in module 'SecondModule'}} +// expected-note@second.h:* {{declaration of 'u' does not match}} +#endif +} + // Interesting cases that should not cause errors. struct S should not error // while struct T should error at the access specifier mismatch at the end. namespace AllDecls {