diff --git a/include/clang/Lex/Preprocessor.h b/include/clang/Lex/Preprocessor.h index db3231ef2b515eae90883670c8365aa45a58b4d8..c4765f099e4c363c86c981b06d44e69a3b82a013 100644 --- a/include/clang/Lex/Preprocessor.h +++ b/include/clang/Lex/Preprocessor.h @@ -408,11 +408,20 @@ class Preprocessor : public RefCountedBase<Preprocessor> { public: MacroState() : MacroState(nullptr) {} MacroState(MacroDirective *MD) : State(MD) {} - void destroy() { + MacroState(MacroState &&O) LLVM_NOEXCEPT : State(O.State) { + O.State = (MacroDirective *)nullptr; + } + MacroState &operator=(MacroState &&O) LLVM_NOEXCEPT { + auto S = O.State; + O.State = (MacroDirective *)nullptr; + State = S; + return *this; + } + ~MacroState() { if (auto *Info = State.dyn_cast<ModuleMacroInfo*>()) Info->~ModuleMacroInfo(); - State = (MacroDirective*)nullptr; } + MacroDirective *getLatest() const { if (auto *Info = State.dyn_cast<ModuleMacroInfo*>()) return Info->MD; diff --git a/lib/Lex/PPLexerChange.cpp b/lib/Lex/PPLexerChange.cpp index 57110aa246fe42ba035fc049a9edf4d34f3101cb..3f0c2bb277675b1ab95b1d4af57ee3dd090d2fae 100644 --- a/lib/Lex/PPLexerChange.cpp +++ b/lib/Lex/PPLexerChange.cpp @@ -638,6 +638,8 @@ void Preprocessor::LeaveSubmodule() { bool ExplicitlyPublic = false; for (auto *MD = Macro.second.getLatest(); MD != SavedInfo.Latest; MD = MD->getPrevious()) { + assert(MD && "broken macro directive chain"); + // Skip macros defined in other submodules we #included along the way. Module *Mod = getModuleContainingLocation(MD->getLocation()); if (Mod != Info.M) @@ -673,7 +675,8 @@ void Preprocessor::LeaveSubmodule() { Info.M->NameVisibility = Module::MacrosVisible; Info.M->MacroVisibilityLoc = Info.ImportLoc; ++MacroVisibilityGeneration; - // FIXME: Also mark any exported macros as visible, and check for conflicts. + // FIXME: Also mark any exported modules as visible, and check for + // conflicts. } BuildingSubmoduleStack.pop_back(); diff --git a/lib/Lex/Preprocessor.cpp b/lib/Lex/Preprocessor.cpp index 80715d548076df1b8bfba00d187cc2dc2b521b03..92ab2af19216bfd347b6a9566a419fa1170186ac 100644 --- a/lib/Lex/Preprocessor.cpp +++ b/lib/Lex/Preprocessor.cpp @@ -142,9 +142,6 @@ Preprocessor::Preprocessor(IntrusiveRefCntPtr<PreprocessorOptions> PPOpts, Preprocessor::~Preprocessor() { assert(BacktrackPositions.empty() && "EnableBacktrack/Backtrack imbalance!"); - for (auto &Macro : Macros) - Macro.second.destroy(); - IncludeMacroStack.clear(); // Destroy any macro definitions.