diff --git a/docs/ReleaseNotes.rst b/docs/ReleaseNotes.rst index be038234df783374d3e1a7d995e25f8d3d6705d7..45bf166068a0529c8589c853c96746f21b8ea183 100644 --- a/docs/ReleaseNotes.rst +++ b/docs/ReleaseNotes.rst @@ -66,6 +66,12 @@ Improvements to Clang's diagnostics a non-default alignment that has been specified using a ``#pragma pack`` directive prior to the ``#include``. +- ``-Wobjc-messaging-id`` is a new, non-default warning that warns about + message sends to unqualified ``id`` in Objective-C. This warning is useful + for projects that would like to avoid any potential future compiler + errors/warnings, as the system frameworks might add a method with the same + selector which could make the message send to ``id`` ambiguous. + Non-comprehensive list of changes in this release ------------------------------------------------- diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td index 37066b467863c28d5280d190699ce54b1f8193e5..04576b60a0eebf20d855944328da21d7b621a923 100644 --- a/include/clang/Basic/DiagnosticSemaKinds.td +++ b/include/clang/Basic/DiagnosticSemaKinds.td @@ -1211,6 +1211,10 @@ def err_objc_method_unsupported_param_ret_type : Error< "%0 %select{parameter|return}1 type is unsupported; " "support for vector types for this target is introduced in %2">; +def warn_messaging_unqualified_id : Warning< + "messaging unqualified id">, DefaultIgnore, + InGroup<DiagGroup<"objc-messaging-id">>; + // C++ declarations def err_static_assert_expression_is_not_constant : Error< "static_assert expression is not an integral constant expression">; diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp index 28581bad1a7a4224a2d47d0522883283a7d9405a..83ef799392aa96523457bec96cc469d2209568dc 100644 --- a/lib/Sema/SemaExprObjC.cpp +++ b/lib/Sema/SemaExprObjC.cpp @@ -2705,6 +2705,9 @@ ExprResult Sema::BuildInstanceMessage(Expr *Receiver, } } + if (ReceiverType->isObjCIdType() && !isImplicit) + Diag(Receiver->getExprLoc(), diag::warn_messaging_unqualified_id); + // There's a somewhat weird interaction here where we assume that we // won't actually have a method unless we also don't need to do some // of the more detailed type-checking on the receiver. diff --git a/test/SemaObjC/warn-messaging-id.mm b/test/SemaObjC/warn-messaging-id.mm new file mode 100644 index 0000000000000000000000000000000000000000..8112cfa3d52175f954c80259ea9cd0e46eb992f2 --- /dev/null +++ b/test/SemaObjC/warn-messaging-id.mm @@ -0,0 +1,21 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class -Wobjc-messaging-id %s + +@interface CallMeMaybe + +- (void)doThing:(int)intThing; + +@property int thing; + +@end + +template<typename T> +void instantiate(const T &x) { + [x setThing: 22]; // expected-warning {{messaging unqualified id}} +} + +void fn() { + id myObject; + [myObject doThing: 10]; // expected-warning {{messaging unqualified id}} + [myObject setThing: 11]; // expected-warning {{messaging unqualified id}} + instantiate(myObject); // expected-note {{in instantiation}} +}