From 9d487242481d41ccf140104fa7ecdee830b45f0c Mon Sep 17 00:00:00 2001
From: Haojian Wu <hokein@google.com>
Date: Thu, 19 Oct 2017 08:20:55 +0000
Subject: [PATCH] Fix a few nits in RenamingAction.
* Add missing override keyword.
* avoid unnecessary copy of std::string.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@316152 91177308-0d34-0410-b5e6-96231b3b80d8
---
lib/Tooling/Refactoring/Rename/RenamingAction.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Tooling/Refactoring/Rename/RenamingAction.cpp b/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
index fdff6fd636a..28912c3e139 100644
--- a/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
+++ b/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
@@ -77,10 +77,10 @@ private:
class RenameOccurrences final : public SourceChangeRefactoringRule {
public:
RenameOccurrences(const NamedDecl *ND, std::string NewName)
- : Finder(ND), NewName(NewName) {}
+ : Finder(ND), NewName(std::move(NewName)) {}
Expected<AtomicChanges>
- createSourceReplacements(RefactoringRuleContext &Context) {
+ createSourceReplacements(RefactoringRuleContext &Context) override {
Expected<SymbolOccurrences> Occurrences =
Finder.findSymbolOccurrences(Context);
if (!Occurrences)
--
GitLab