diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index f51e1f6778838e2cb13112fcbda618cdcfb254b3..1e46434ef9aac70aa983f0a62ccef6323c561505 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -8948,7 +8948,16 @@ static void AddRunTimeLibs(const ToolChain &TC, const Driver &D, } break; case ToolChain::RLT_Libgcc: - AddLibgcc(TC.getTriple(), D, CmdArgs, Args); + // Make sure libgcc is not used under MSVC environment by default + if (TC.getTriple().isKnownWindowsMSVCEnvironment()) { + // Issue error diagnostic if libgcc is explicitly specified + // through command line as --rtlib option argument. + if (Args.hasArg(options::OPT_rtlib_EQ)) { + TC.getDriver().Diag(diag::err_drv_unsupported_rtlib_for_platform) + << Args.getLastArg(options::OPT_rtlib_EQ)->getValue() << "MSVC"; + } + } else + AddLibgcc(TC.getTriple(), D, CmdArgs, Args); break; } } @@ -9754,6 +9763,12 @@ void visualstudio::Linker::ConstructJob(Compilation &C, const JobAction &JA, } } + // Add compiler-rt lib in case if it was explicitly + // specified as an argument for --rtlib option. + if (!Args.hasArg(options::OPT_nostdlib)) { + AddRunTimeLibs(TC, TC.getDriver(), CmdArgs, Args); + } + // Add filenames, libraries, and other linker inputs. for (const auto &Input : Inputs) { if (Input.isFilename()) { diff --git a/test/Driver/msvc-compiler-rt.c b/test/Driver/msvc-compiler-rt.c new file mode 100644 index 0000000000000000000000000000000000000000..abbca507ae7f40452b3c411d2a6432be225270cf --- /dev/null +++ b/test/Driver/msvc-compiler-rt.c @@ -0,0 +1,5 @@ +// RUN: %clang -target x86_64-pc-windows-msvc --rtlib=compiler-rt -### %s 2>&1 | FileCheck %s -check-prefix MSVC-COMPILER-RT +// RUN: not %clang %s -target x86_64-pc-windows-msvc --rtlib=libgcc 2>&1 | FileCheck %s -check-prefix CHECK-ERROR + +// MSVC-COMPILER-RT: "{{.*}}clang_rt.builtins{{.*}}" +// CHECK-ERROR: unsupported runtime library 'libgcc' for platform 'MSVC' diff --git a/test/Driver/nostdlib.c b/test/Driver/nostdlib.c index 47c6f8bacd4644f221bd11bbe0c23588541cc9ee..6e7bc0eb93ec9ffa2dd336ff4990e5871c0471c8 100644 --- a/test/Driver/nostdlib.c +++ b/test/Driver/nostdlib.c @@ -22,6 +22,10 @@ // RUN: -resource-dir=%S/Inputs/resource_dir -lclang_rt.builtins-i686 \ // RUN: | FileCheck --check-prefix=CHECK-LINUX-NOSTDLIB %s // +// RUN: %clang -target x86_64-pc-windows-msvc -nostdlib --rtlib=compiler-rt -### %s 2>&1 | FileCheck %s -check-prefix CHECK-MSVC-NOSTDLIB +// RUN: %clang -target x86_64-pc-windows-msvc --rtlib=compiler-rt -nostdlib -### %s 2>&1 | FileCheck %s -check-prefix CHECK-MSVC-NOSTDLIB +// // CHECK-LINUX-NOSTDLIB: warning: argument unused during compilation: '--rtlib=compiler-rt' // CHECK-LINUX-NOSTDLIB: "{{(.*[^.0-9A-Z_a-z])?}}ld{{(.exe)?}}" // CHECK-LINUX-NOSTDLIB-NOT: "{{.*}}/Inputs/resource_dir{{/|\\\\}}lib{{/|\\\\}}linux{{/|\\\\}}libclang_rt.builtins-i686.a" +// CHECK-MSVC-NOSTDLIB: warning: argument unused during compilation: '--rtlib=compiler-rt'