diff --git a/include/clang/Index/CommentToXML.h b/include/clang/Index/CommentToXML.h index c68d7a47d51151d4ce9dc1e7adbd3153cf037fb8..bb7b71ad411b66b47d65e125e1d5c433f7a65f6a 100644 --- a/include/clang/Index/CommentToXML.h +++ b/include/clang/Index/CommentToXML.h @@ -11,6 +11,7 @@ #define LLVM_CLANG_INDEX_COMMENTTOXML_H #include "clang/Basic/LLVM.h" +#include <memory> namespace clang { class ASTContext; @@ -24,11 +25,11 @@ namespace index { class SimpleFormatContext; class CommentToXMLConverter { - SimpleFormatContext *FormatContext; + std::unique_ptr<SimpleFormatContext> FormatContext; unsigned FormatInMemoryUniqueId; public: - CommentToXMLConverter() : FormatContext(0), FormatInMemoryUniqueId(0) {} + CommentToXMLConverter(); ~CommentToXMLConverter(); void convertCommentToHTML(const comments::FullComment *FC, diff --git a/lib/Index/CommentToXML.cpp b/lib/Index/CommentToXML.cpp index 54087bd87d75ceceba00b3d57a59148b74ccc32f..a668c5676b3d8e6ea6ad4fbd383e908f03a31bcf 100644 --- a/lib/Index/CommentToXML.cpp +++ b/lib/Index/CommentToXML.cpp @@ -1136,9 +1136,8 @@ void CommentASTToXMLConverter::appendToResultWithCDATAEscaping(StringRef S) { Result << "]]>"; } -CommentToXMLConverter::~CommentToXMLConverter() { - delete FormatContext; -} +CommentToXMLConverter::CommentToXMLConverter() : FormatInMemoryUniqueId(0) {} +CommentToXMLConverter::~CommentToXMLConverter() = default; void CommentToXMLConverter::convertCommentToHTML(const FullComment *FC, SmallVectorImpl<char> &HTML, @@ -1159,13 +1158,10 @@ void CommentToXMLConverter::convertHTMLTagNodeToText( void CommentToXMLConverter::convertCommentToXML(const FullComment *FC, SmallVectorImpl<char> &XML, const ASTContext &Context) { - if (!FormatContext) { - FormatContext = new SimpleFormatContext(Context.getLangOpts()); - } else if ((FormatInMemoryUniqueId % 1000) == 0) { - // Delete after some number of iterations, so the buffers don't grow - // too large. - delete FormatContext; - FormatContext = new SimpleFormatContext(Context.getLangOpts()); + if (!FormatContext || (FormatInMemoryUniqueId % 1000) == 0) { + // Create a new format context, or re-create it after some number of + // iterations, so the buffers don't grow too large. + FormatContext.reset(new SimpleFormatContext(Context.getLangOpts())); } CommentASTToXMLConverter Converter(FC, XML, Context.getCommentCommandTraits(),