diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index 129b25cd211c303747050bb7887777995a28bc8d..98724ee2041a9ca973d7c7797c3faa7a911bc965 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -4602,8 +4602,6 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, bool splitDwarfInlining = Args.hasFlag(options::OPT_fsplit_dwarf_inlining, options::OPT_fno_split_dwarf_inlining, true); - if (!splitDwarfInlining) - CmdArgs.push_back("-fno-split-dwarf-inlining"); Args.ClaimAllArgs(options::OPT_g_Group); Arg *SplitDwarfArg = Args.getLastArg(options::OPT_gsplit_dwarf); @@ -4619,11 +4617,15 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, // split-dwarf and line-tables-only, so let those compose naturally in // that case. // And if you just turned off debug info, (-gsplit-dwarf -g0) - do that. - if (SplitDwarfArg && A->getIndex() > SplitDwarfArg->getIndex() && - ((DebugInfoKind == codegenoptions::DebugLineTablesOnly && - splitDwarfInlining) || - DebugInfoKind == codegenoptions::NoDebugInfo)) - SplitDwarfArg = nullptr; + if (SplitDwarfArg) { + if (A->getIndex() > SplitDwarfArg->getIndex()) { + if (DebugInfoKind == codegenoptions::NoDebugInfo || + (DebugInfoKind == codegenoptions::DebugLineTablesOnly && + splitDwarfInlining)) + SplitDwarfArg = nullptr; + } else if (splitDwarfInlining) + DebugInfoKind = codegenoptions::NoDebugInfo; + } } else // For any other 'g' option, use Limited. DebugInfoKind = codegenoptions::LimitedDebugInfo; @@ -4678,7 +4680,9 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, // splitting and extraction. // FIXME: Currently only works on Linux. if (getToolChain().getTriple().isOSLinux() && SplitDwarfArg) { - if (splitDwarfInlining) + if (!splitDwarfInlining) + CmdArgs.push_back("-fno-split-dwarf-inlining"); + if (DebugInfoKind == codegenoptions::NoDebugInfo) DebugInfoKind = codegenoptions::LimitedDebugInfo; CmdArgs.push_back("-backend-option"); CmdArgs.push_back("-split-dwarf=Enable"); diff --git a/test/Driver/split-debug.c b/test/Driver/split-debug.c index 6c69346646a43e085a4d220a9dbb748df55dfd90..eaa1e990c04cf89dd0f20730384083052f264f17 100644 --- a/test/Driver/split-debug.c +++ b/test/Driver/split-debug.c @@ -47,6 +47,13 @@ // CHECK-SPLIT-WITH-GMLT: "-debug-info-kind=line-tables-only" // CHECK-SPLIT-WITH-GMLT: "-split-dwarf-file" +// RUN: %clang -target x86_64-unknown-linux-gnu -gsplit-dwarf -fno-split-dwarf-inlining -S -### %s 2> %t +// RUN: FileCheck -check-prefix=CHECK-SPLIT-WITH-NOINL < %t %s +// +// CHECK-SPLIT-WITH-NOINL: "-split-dwarf=Enable" +// CHECK-SPLIT-WITH-NOINL: "-debug-info-kind=limited" +// CHECK-SPLIT-WITH-NOINL: "-split-dwarf-file" + // RUN: %clang -target x86_64-unknown-linux-gnu -gsplit-dwarf -gmlt -S -### %s 2> %t // RUN: FileCheck -check-prefix=CHECK-GMLT-OVER-SPLIT < %t %s //