diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp index d8b801bf0a692ec7986bdd81932d789d912da8f5..f6bb8370d5371921cb7fe8eed833b4a910abf215 100644 --- a/lib/Sema/SemaChecking.cpp +++ b/lib/Sema/SemaChecking.cpp @@ -4943,6 +4943,8 @@ struct IntRange { T = VT->getElementType().getTypePtr(); if (const ComplexType *CT = dyn_cast<ComplexType>(T)) T = CT->getElementType().getTypePtr(); + if (const AtomicType *AT = dyn_cast<AtomicType>(T)) + T = AT->getValueType().getTypePtr(); // For enum types, use the known bit width of the enumerators. if (const EnumType *ET = dyn_cast<EnumType>(T)) { @@ -4978,6 +4980,8 @@ struct IntRange { T = VT->getElementType().getTypePtr(); if (const ComplexType *CT = dyn_cast<ComplexType>(T)) T = CT->getElementType().getTypePtr(); + if (const AtomicType *AT = dyn_cast<AtomicType>(T)) + T = AT->getValueType().getTypePtr(); if (const EnumType *ET = dyn_cast<EnumType>(T)) T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); @@ -5380,6 +5384,8 @@ static void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, // TODO: Investigate using GetExprRange() to get tighter bounds // on the bit ranges. QualType OtherT = Other->getType(); + if (const AtomicType *AT = dyn_cast<AtomicType>(OtherT)) + OtherT = AT->getValueType(); IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); unsigned OtherWidth = OtherRange.Width; diff --git a/test/Sema/atomic-compare.c b/test/Sema/atomic-compare.c new file mode 100644 index 0000000000000000000000000000000000000000..2eed091260267d3002d490ac695a3b2bfe5d383b --- /dev/null +++ b/test/Sema/atomic-compare.c @@ -0,0 +1,21 @@ +// RUN: %clang_cc1 %s -verify -fsyntax-only + +void f(_Atomic(int) a, _Atomic(int) b) { + if (a > b) {} // no warning + if (a < b) {} // no warning + if (a >= b) {} // no warning + if (a <= b) {} // no warning + if (a == b) {} // no warning + if (a != b) {} // no warning + + if (a == 0) {} // no warning + if (a > 0) {} // no warning + if (a > 1) {} // no warning + if (a > 2) {} // no warning + + if (!a > 0) {} // no warning + if (!a > 1) {} // expected-warning {{comparison of constant 1 with boolean expression is always false}} + if (!a > 2) {} // expected-warning {{comparison of constant 2 with boolean expression is always false}} + if (!a > b) {} // no warning + if (!a > -1) {} // expected-warning {{comparison of constant -1 with boolean expression is always true}} +} diff --git a/test/Sema/atomic-expr.c b/test/Sema/atomic-expr.c index 5602d545cc7f97d89089cdc08d7b133db2784b25..997ee90e9f3b075f3104cdf15b3c9d3229a5aee6 100644 --- a/test/Sema/atomic-expr.c +++ b/test/Sema/atomic-expr.c @@ -58,3 +58,6 @@ int func_13 (int x, unsigned y) { return x ? data1 : y; } +int func_14 () { + return data1 == 0; +}