diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index c5499dea769154a2822c865b4caa9bef08124258..0ed010e4ea3385afed45433d817100a5b19138fc 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -1200,10 +1200,18 @@ void Clang::AddX86TargetArgs(const ArgList &Args, Args.hasArg(options::OPT_fapple_kext)) CmdArgs.push_back("-disable-red-zone"); - if (Args.hasFlag(options::OPT_msoft_float, - options::OPT_mno_soft_float, - false) || - Args.hasArg(options::OPT_mno_implicit_float)) + // Default to avoid implicit floating-point for kernel/kext code, but allow + // that to be overridden with -mno-soft-float. + bool NoImplicitFloat = (Args.hasArg(options::OPT_mkernel) || + Args.hasArg(options::OPT_fapple_kext)); + if (Arg *A = Args.getLastArg(options::OPT_msoft_float, + options::OPT_mno_soft_float, + options::OPT_mno_implicit_float)) { + const Option &O = A->getOption(); + NoImplicitFloat = (O.matches(options::OPT_mno_implicit_float) || + O.matches(options::OPT_msoft_float)); + } + if (NoImplicitFloat) CmdArgs.push_back("-no-implicit-float"); if (const char *CPUName = getX86TargetCPU(Args, getToolChain().getTriple())) { diff --git a/test/Driver/flags.c b/test/Driver/flags.c index d328b827bb62f341bbe906e8f87ffbf926ee6631..27862316f88f983451c56180a4f3262c1510aaf8 100644 --- a/test/Driver/flags.c +++ b/test/Driver/flags.c @@ -10,5 +10,11 @@ // RUN: %clang -target i386-apple-darwin9 -### -S -mno-implicit-float %s 2> %t.log // RUN: grep '"-no-implicit-float"' %t.log +// RUN: %clang -target i386-apple-darwin9 -### -S -mkernel %s 2> %t.log +// RUN: grep '"-no-implicit-float"' %t.log + +// RUN: %clang -target i386-apple-darwin9 -### -S -mkernel -mno-soft-float %s 2> %t.log +// RUN: grep '"-no-implicit-float"' %t.log | count 0 + // RUN: %clang -target armv7-apple-darwin10 -### -S -mno-implicit-float %s 2> %t.log // RUN: grep '"-no-implicit-float"' %t.log