Skip to content
Snippets Groups Projects
  • Adam Nemet's avatar
    8a7af2f3
    Reapply r281276 with passing -emit-llvm in one of the tests · 8a7af2f3
    Adam Nemet authored
    Original commit message:
    
    Add -fdiagnostics-show-hotness
    
    Summary:
    I've recently added the ability for optimization remarks to include the
    hotness of the corresponding code region.  This uses PGO and allows
    filtering of the optimization remarks by relevance.  The idea was first
    discussed here:
    http://thread.gmane.org/gmane.comp.compilers.llvm.devel/98334
    
    The general goal is to produce a YAML file with the remarks.  Then, an
    external tool could dynamically filter these by hotness and perhaps by
    other things.
    
    That said it makes sense to also expose this at the more basic level
    where we just include the hotness info with each optimization remark.
    For example, in D22694, the clang flag was pretty useful to measure the
    overhead of the additional analyses required to include hotness.
    (Without the flag we don't even run the analyses.)
    
    For the record, Hal has already expressed support for the idea of this
    patch on IRC.
    
    Differential Revision: https://reviews.llvm.org/D23284
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@281293 91177308-0d34-0410-b5e6-96231b3b80d8
    8a7af2f3
    History
    Reapply r281276 with passing -emit-llvm in one of the tests
    Adam Nemet authored
    Original commit message:
    
    Add -fdiagnostics-show-hotness
    
    Summary:
    I've recently added the ability for optimization remarks to include the
    hotness of the corresponding code region.  This uses PGO and allows
    filtering of the optimization remarks by relevance.  The idea was first
    discussed here:
    http://thread.gmane.org/gmane.comp.compilers.llvm.devel/98334
    
    The general goal is to produce a YAML file with the remarks.  Then, an
    external tool could dynamically filter these by hotness and perhaps by
    other things.
    
    That said it makes sense to also expose this at the more basic level
    where we just include the hotness info with each optimization remark.
    For example, in D22694, the clang flag was pretty useful to measure the
    overhead of the additional analyses required to include hotness.
    (Without the flag we don't even run the analyses.)
    
    For the record, Hal has already expressed support for the idea of this
    patch on IRC.
    
    Differential Revision: https://reviews.llvm.org/D23284
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@281293 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.