Skip to content
Snippets Groups Projects
  • Alp Toker's avatar
    7225802b
    Hide the concept of diagnostic levels from lex, parse and sema · 7225802b
    Alp Toker authored
    The compilation pipeline doesn't actually need to know about the high-level
    concept of diagnostic mappings, and hiding the final computed level presents
    several simplifications and other potential benefits.
    
    The only exceptions are opportunistic checks to see whether expensive code
    paths can be avoided for diagnostics that are guaranteed to be ignored at a
    certain SourceLocation.
    
    This commit formalizes that invariant by introducing and using
    DiagnosticsEngine::isIgnored() in place of individual level checks throughout
    lex, parse and sema.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@211005 91177308-0d34-0410-b5e6-96231b3b80d8
    7225802b
    History
    Hide the concept of diagnostic levels from lex, parse and sema
    Alp Toker authored
    The compilation pipeline doesn't actually need to know about the high-level
    concept of diagnostic mappings, and hiding the final computed level presents
    several simplifications and other potential benefits.
    
    The only exceptions are opportunistic checks to see whether expensive code
    paths can be avoided for diagnostics that are guaranteed to be ignored at a
    certain SourceLocation.
    
    This commit formalizes that invariant by introducing and using
    DiagnosticsEngine::isIgnored() in place of individual level checks throughout
    lex, parse and sema.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@211005 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.