Skip to content
Snippets Groups Projects
  • Douglas Gregor's avatar
    200b2921
    When we run into an error parsing or type-checking the left-hand side · 200b2921
    Douglas Gregor authored
    of a binary expression, continue on and parse the right-hand side of
    the binary expression anyway, but don't call the semantic actions to
    type-check. Previously, we would see the error and then, effectively,
    skip tokens until the end of the statement. 
    
    The result should be more useful recovery, both in the normal case
    (we'll actually see errors beyond the first one in a statement), but
    it also helps code completion do a much better job, because we do
    "real" code completion on the right-hand side of an invalid binary
    expression rather than completing with the recovery completion. For
    example, given
    
      x = p->y
    
    if there is no variable named "x", we can still complete after the p->
    as a member expression. Along the recovery path, we would have
    completed after the "->" as if we were in an expression context, which
    is mostly useless.
    
    
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@114225 91177308-0d34-0410-b5e6-96231b3b80d8
    200b2921
    History
    When we run into an error parsing or type-checking the left-hand side
    Douglas Gregor authored
    of a binary expression, continue on and parse the right-hand side of
    the binary expression anyway, but don't call the semantic actions to
    type-check. Previously, we would see the error and then, effectively,
    skip tokens until the end of the statement. 
    
    The result should be more useful recovery, both in the normal case
    (we'll actually see errors beyond the first one in a statement), but
    it also helps code completion do a much better job, because we do
    "real" code completion on the right-hand side of an invalid binary
    expression rather than completing with the recovery completion. For
    example, given
    
      x = p->y
    
    if there is no variable named "x", we can still complete after the p->
    as a member expression. Along the recovery path, we would have
    completed after the "->" as if we were in an expression context, which
    is mostly useless.
    
    
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@114225 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.