Skip to content
Snippets Groups Projects
  • Lang Hames's avatar
    30060bff
    Call setMustBuildLookupTable on TagDecls in ExternalASTMerger · 30060bff
    Lang Hames authored
    Summary:
    setMustBuildLookupTable should be called on imported TagDecls otherwise we may fail
    to import their member decls (if they have any).
    
    Not calling the setMustBuildLookupTable method results in a failure in the attached test
    case when lookup for the 'x' member fails on struct S, which hasn't had its decls imported
    elsewhere. (By contrast the member-in-struct testcase hasn't run into this issue
    because the import of its decls is triggered when the struct instance is defined, and the
    member access follows this).
    
    Reviewers: spyffe, rsmith
    
    Reviewed By: spyffe, rsmith
    
    Differential Revision: https://reviews.llvm.org/D34253
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@305619 91177308-0d34-0410-b5e6-96231b3b80d8
    30060bff
    History
    Call setMustBuildLookupTable on TagDecls in ExternalASTMerger
    Lang Hames authored
    Summary:
    setMustBuildLookupTable should be called on imported TagDecls otherwise we may fail
    to import their member decls (if they have any).
    
    Not calling the setMustBuildLookupTable method results in a failure in the attached test
    case when lookup for the 'x' member fails on struct S, which hasn't had its decls imported
    elsewhere. (By contrast the member-in-struct testcase hasn't run into this issue
    because the import of its decls is triggered when the struct instance is defined, and the
    member access follows this).
    
    Reviewers: spyffe, rsmith
    
    Reviewed By: spyffe, rsmith
    
    Differential Revision: https://reviews.llvm.org/D34253
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@305619 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.