Skip to content
Snippets Groups Projects
  • Justin Lebar's avatar
    45b902e6
    [CUDA] Emit deferred diagnostics during Sema rather than during codegen. · 45b902e6
    Justin Lebar authored
    Summary:
    Emitting deferred diagnostics during codegen was a hack.  It did work,
    but usability was poor, both for us as compiler devs and for users.  We
    don't codegen if there are any sema errors, so for users this meant that
    they wouldn't see deferred errors if there were any non-deferred errors.
    For devs, this meant that we had to carefully split up our tests so that
    when we tested deferred errors, we didn't emit any non-deferred errors.
    
    This change moves checking for deferred errors into Sema.  See the big
    comment in SemaCUDA.cpp for an overview of the idea.
    
    This checking adds overhead to compilation, because we have to maintain
    a partial call graph.  As a result, this change makes deferred errors a
    CUDA-only concept (whereas before they were a general concept).  If
    anyone else wants to use this framework for something other than CUDA,
    we can generalize at that time.
    
    This patch makes the minimal set of test changes -- after this lands,
    I'll go back through and do a cleanup of the tests that we no longer
    have to split up.
    
    Reviewers: rnk
    
    Subscribers: cfe-commits, rsmith, tra
    
    Differential Revision: https://reviews.llvm.org/D25541
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@284158 91177308-0d34-0410-b5e6-96231b3b80d8
    45b902e6
    History
    [CUDA] Emit deferred diagnostics during Sema rather than during codegen.
    Justin Lebar authored
    Summary:
    Emitting deferred diagnostics during codegen was a hack.  It did work,
    but usability was poor, both for us as compiler devs and for users.  We
    don't codegen if there are any sema errors, so for users this meant that
    they wouldn't see deferred errors if there were any non-deferred errors.
    For devs, this meant that we had to carefully split up our tests so that
    when we tested deferred errors, we didn't emit any non-deferred errors.
    
    This change moves checking for deferred errors into Sema.  See the big
    comment in SemaCUDA.cpp for an overview of the idea.
    
    This checking adds overhead to compilation, because we have to maintain
    a partial call graph.  As a result, this change makes deferred errors a
    CUDA-only concept (whereas before they were a general concept).  If
    anyone else wants to use this framework for something other than CUDA,
    we can generalize at that time.
    
    This patch makes the minimal set of test changes -- after this lands,
    I'll go back through and do a cleanup of the tests that we no longer
    have to split up.
    
    Reviewers: rnk
    
    Subscribers: cfe-commits, rsmith, tra
    
    Differential Revision: https://reviews.llvm.org/D25541
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@284158 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.