Skip to content
Snippets Groups Projects
  • Chandler Carruth's avatar
    4e57f52f
    Revert r290149: Add the alloc_size attribute to clang. · 4e57f52f
    Chandler Carruth authored
    This commit fails MSan when running test/CodeGen/object-size.c in
    a confusing way. After some discussion with George, it isn't really
    clear what is going on here. We can make the MSan failure go away by
    testing for the invalid bit, but *why* things are invalid isn't clear.
    And yet, other code in the surrounding area is doing precisely this and
    testing for invalid.
    
    George is going to take a closer look at this to better understand the
    nature of the failure and recommit it, for now backing it out to clean
    up MSan builds.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@290169 91177308-0d34-0410-b5e6-96231b3b80d8
    4e57f52f
    History
    Revert r290149: Add the alloc_size attribute to clang.
    Chandler Carruth authored
    This commit fails MSan when running test/CodeGen/object-size.c in
    a confusing way. After some discussion with George, it isn't really
    clear what is going on here. We can make the MSan failure go away by
    testing for the invalid bit, but *why* things are invalid isn't clear.
    And yet, other code in the surrounding area is doing precisely this and
    testing for invalid.
    
    George is going to take a closer look at this to better understand the
    nature of the failure and recommit it, for now backing it out to clean
    up MSan builds.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@290169 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.