Skip to content
Snippets Groups Projects
  • Justin Bogner's avatar
    e6ff2fc8
    Lex: Fix __has_feature(cxx_exceptions) for objective C++ · e6ff2fc8
    Justin Bogner authored
    At one point, -fexceptions was a synonym for -fcxx-exceptions. While
    the driver options still enables cxx-exceptions by default, the cc1
    flag is purely about exception tables and this doesn't account for
    objective C exceptions. Because of this, checking for the
    cxx_exceptions feature in objective C++ often gives the wrong answer.
    
    The cxx_exceptions feature should be based on the -fcxx-exceptions cc1
    flag, not -fexceptions. Furthermore, at some point the tests were
    changed to use cc1 even though they were testing the driver behaviour.
    We're better off testing both the driver and cc1 here.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@206352 91177308-0d34-0410-b5e6-96231b3b80d8
    e6ff2fc8
    History
    Lex: Fix __has_feature(cxx_exceptions) for objective C++
    Justin Bogner authored
    At one point, -fexceptions was a synonym for -fcxx-exceptions. While
    the driver options still enables cxx-exceptions by default, the cc1
    flag is purely about exception tables and this doesn't account for
    objective C exceptions. Because of this, checking for the
    cxx_exceptions feature in objective C++ often gives the wrong answer.
    
    The cxx_exceptions feature should be based on the -fcxx-exceptions cc1
    flag, not -fexceptions. Furthermore, at some point the tests were
    changed to use cc1 even though they were testing the driver behaviour.
    We're better off testing both the driver and cc1 here.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@206352 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.