Skip to content
Snippets Groups Projects
  • Krasimir Georgiev's avatar
    51ee6cef
    [clang-format] Keep trailing preprocessor line comments separate from the... · 51ee6cef
    Krasimir Georgiev authored
    [clang-format] Keep trailing preprocessor line comments separate from the following section comments
    
    Summary:
    r303415 changed the way a sequence of line comments following a preprocessor
    macro is handled, which has the unfortunate effect of aligning a trailing
    preprocessor line comment and following unrelated section comments, so:
    ```
    #ifdef A // comment about A
    // section comment
    #endif
    ```
    gets turned into:
    ```
    #ifdef A // comment about A
             // section comment
    #endif
    ```
    This patch fixes this by additionally checking the original start columns of
    the line comments.
    
    Reviewers: djasper
    
    Reviewed By: djasper
    
    Subscribers: klimek, cfe-commits
    
    Differential Revision: https://reviews.llvm.org/D33394
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@303541 91177308-0d34-0410-b5e6-96231b3b80d8
    51ee6cef
    History
    [clang-format] Keep trailing preprocessor line comments separate from the...
    Krasimir Georgiev authored
    [clang-format] Keep trailing preprocessor line comments separate from the following section comments
    
    Summary:
    r303415 changed the way a sequence of line comments following a preprocessor
    macro is handled, which has the unfortunate effect of aligning a trailing
    preprocessor line comment and following unrelated section comments, so:
    ```
    #ifdef A // comment about A
    // section comment
    #endif
    ```
    gets turned into:
    ```
    #ifdef A // comment about A
             // section comment
    #endif
    ```
    This patch fixes this by additionally checking the original start columns of
    the line comments.
    
    Reviewers: djasper
    
    Reviewed By: djasper
    
    Subscribers: klimek, cfe-commits
    
    Differential Revision: https://reviews.llvm.org/D33394
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@303541 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.