Skip to content
Snippets Groups Projects
  • Florian Hahn's avatar
    c4f2a80f
    [Driver] Error if ARM mode was selected explicitly for M-profile CPUs. · c4f2a80f
    Florian Hahn authored
    Summary:
    M-class profiles do not support ARM execution mode, so providing
    -marm/-mno-thumb does not make sense in combination with -mcpu/-march
    options that support the M-profile.
    
    This is a follow-up patch to D35569 and it seemed pretty clear that we
    should emit an error in the driver in this case.
    
    We probably also should warn/error if the provided -mcpu/-march options
    do not match, e.g. -mcpu=cortex-m0 -march=armv8-a is invalid, as
    cortex-m0 does not support armv8-a. But that should be a separate patch
    I think.
    
    
    Reviewers: echristo, richard.barton.arm, rengolin, labrinea, charles.baylis
    
    Reviewed By: rengolin
    
    Subscribers: aemerson, javed.absar, kristof.beyls, cfe-commits
    
    Differential Revision: https://reviews.llvm.org/D35826
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@310047 91177308-0d34-0410-b5e6-96231b3b80d8
    c4f2a80f
    History
    [Driver] Error if ARM mode was selected explicitly for M-profile CPUs.
    Florian Hahn authored
    Summary:
    M-class profiles do not support ARM execution mode, so providing
    -marm/-mno-thumb does not make sense in combination with -mcpu/-march
    options that support the M-profile.
    
    This is a follow-up patch to D35569 and it seemed pretty clear that we
    should emit an error in the driver in this case.
    
    We probably also should warn/error if the provided -mcpu/-march options
    do not match, e.g. -mcpu=cortex-m0 -march=armv8-a is invalid, as
    cortex-m0 does not support armv8-a. But that should be a separate patch
    I think.
    
    
    Reviewers: echristo, richard.barton.arm, rengolin, labrinea, charles.baylis
    
    Reviewed By: rengolin
    
    Subscribers: aemerson, javed.absar, kristof.beyls, cfe-commits
    
    Differential Revision: https://reviews.llvm.org/D35826
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@310047 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.