Skip to content
Snippets Groups Projects
  • Chris Bieneman's avatar
    7c599a54
    [CMake] Remove CLANG_APPEND_VC_REV option · 7c599a54
    Chris Bieneman authored
    I added this option in r257827 to try and add compatibility with autoconf. At the time I misunderstood the problem.
    
    Our CMake automatically generates the SVN revision information and generates a build action to update it so builds don't need to be re-configured on SCM update (which is a better solution than we had in autoconf).
    
    The problem I was actually seeing was isolated cases where SVN revision information isn't available because the repository structures have been removed. This happens in some automated testing systems.
    
    This patch allows SVN_REVISION to be overridden if the build configuration could not find the SCM repository structures, and removes the code from my original patch because it is unnecessary.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@273714 91177308-0d34-0410-b5e6-96231b3b80d8
    7c599a54
    History
    [CMake] Remove CLANG_APPEND_VC_REV option
    Chris Bieneman authored
    I added this option in r257827 to try and add compatibility with autoconf. At the time I misunderstood the problem.
    
    Our CMake automatically generates the SVN revision information and generates a build action to update it so builds don't need to be re-configured on SCM update (which is a better solution than we had in autoconf).
    
    The problem I was actually seeing was isolated cases where SVN revision information isn't available because the repository structures have been removed. This happens in some automated testing systems.
    
    This patch allows SVN_REVISION to be overridden if the build configuration could not find the SCM repository structures, and removes the code from my original patch because it is unnecessary.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@273714 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.