Skip to content
Snippets Groups Projects
  • Ben Langmuir's avatar
    d066fe94
    Reapply fixed "Honour 'use-external-names' in FileManager" · d066fe94
    Ben Langmuir authored
    Was r202442
    
    There were two issues with the original patch that have now been fixed.
    1. We were memset'ing over a FileEntry in a test case. After adding a
       std::string to FileEntry, this still happened to not break for me.
    2. I didn't pass the FileManager into the new compiler instance in
       compileModule. This was hidden in some cases by the fact I didn't
       clear the module cache in the test.
    
    Also, I changed the copy constructor for FileEntry, which was memcpy'ing
    in a (now) unsafe way.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@202539 91177308-0d34-0410-b5e6-96231b3b80d8
    d066fe94
    History
    Reapply fixed "Honour 'use-external-names' in FileManager"
    Ben Langmuir authored
    Was r202442
    
    There were two issues with the original patch that have now been fixed.
    1. We were memset'ing over a FileEntry in a test case. After adding a
       std::string to FileEntry, this still happened to not break for me.
    2. I didn't pass the FileManager into the new compiler instance in
       compileModule. This was hidden in some cases by the fact I didn't
       clear the module cache in the test.
    
    Also, I changed the copy constructor for FileEntry, which was memcpy'ing
    in a (now) unsafe way.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@202539 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.