Skip to content
Snippets Groups Projects
  • Gabor Horvath's avatar
    222b56d7
    [ASTMatchers] Existing matcher hasAnyArgument fixed · 222b56d7
    Gabor Horvath authored
    Summary: A checker (will be uploaded after this patch) needs to check implicit casts. The checker needs matcher hasAnyArgument but it ignores implicit casts and parenthesized expressions which disables checking of implicit casts for arguments in the checker. However the documentation of the matcher contains a FIXME that this should be removed once separate matchers for ignoring implicit casts and parenthesized expressions are ready. Since these matchers were already there the fix could be executed. Only one Clang checker was affected which was also fixed (ignoreParenImpCasts added) and is separately uploaded. Third party checkers (not in the Clang repository) may be affected by this fix so the fix must be emphasized in the release notes.
    
    Reviewers: klimek, sbenza, alexfh
    
    Subscribers: alexfh, klimek, xazax.hun, cfe-commits
    
    Differential Revision: http://reviews.llvm.org/D18243
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@264855 91177308-0d34-0410-b5e6-96231b3b80d8
    222b56d7
    History
    [ASTMatchers] Existing matcher hasAnyArgument fixed
    Gabor Horvath authored
    Summary: A checker (will be uploaded after this patch) needs to check implicit casts. The checker needs matcher hasAnyArgument but it ignores implicit casts and parenthesized expressions which disables checking of implicit casts for arguments in the checker. However the documentation of the matcher contains a FIXME that this should be removed once separate matchers for ignoring implicit casts and parenthesized expressions are ready. Since these matchers were already there the fix could be executed. Only one Clang checker was affected which was also fixed (ignoreParenImpCasts added) and is separately uploaded. Third party checkers (not in the Clang repository) may be affected by this fix so the fix must be emphasized in the release notes.
    
    Reviewers: klimek, sbenza, alexfh
    
    Subscribers: alexfh, klimek, xazax.hun, cfe-commits
    
    Differential Revision: http://reviews.llvm.org/D18243
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@264855 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.