Skip to content
Snippets Groups Projects
  • John McCall's avatar
    f4ddf94e
    Compute and preserve alignment more faithfully in IR-generation. · f4ddf94e
    John McCall authored
    Introduce an Address type to bundle a pointer value with an
    alignment.  Introduce APIs on CGBuilderTy to work with Address
    values.  Change core APIs on CGF/CGM to traffic in Address where
    appropriate.  Require alignments to be non-zero.  Update a ton
    of code to compute and propagate alignment information.
    
    As part of this, I've promoted CGBuiltin's EmitPointerWithAlignment
    helper function to CGF and made use of it in a number of places in
    the expression emitter.
    
    The end result is that we should now be significantly more correct
    when performing operations on objects that are locally known to
    be under-aligned.  Since alignment is not reliably tracked in the
    type system, there are inherent limits to this, but at least we
    are no longer confused by standard operations like derived-to-base
    conversions and array-to-pointer decay.  I've also fixed a large
    number of bugs where we were applying the complete-object alignment
    to a pointer instead of the non-virtual alignment, although most of
    these were hidden by the very conservative approach we took with
    member alignment.
    
    Also, because IRGen now reliably asserts on zero alignments, we
    should no longer be subject to an absurd but frustrating recurring
    bug where an incomplete type would report a zero alignment and then
    we'd naively do a alignmentAtOffset on it and emit code using an
    alignment equal to the largest power-of-two factor of the offset.
    
    We should also now be emitting much more aggressive alignment
    attributes in the presence of over-alignment.  In particular,
    field access now uses alignmentAtOffset instead of min.
    
    Several times in this patch, I had to change the existing
    code-generation pattern in order to more effectively use
    the Address APIs.  For the most part, this seems to be a strict
    improvement, like doing pointer arithmetic with GEPs instead of
    ptrtoint.  That said, I've tried very hard to not change semantics,
    but it is likely that I've failed in a few places, for which I
    apologize.
    
    ABIArgInfo now always carries the assumed alignment of indirect and
    indirect byval arguments.  In order to cut down on what was already
    a dauntingly large patch, I changed the code to never set align
    attributes in the IR on non-byval indirect arguments.  That is,
    we still generate code which assumes that indirect arguments have
    the given alignment, but we don't express this information to the
    backend except where it's semantically required (i.e. on byvals).
    This is likely a minor regression for those targets that did provide
    this information, but it'll be trivial to add it back in a later
    patch.
    
    I partially punted on applying this work to CGBuiltin.  Please
    do not add more uses of the CreateDefaultAligned{Load,Store}
    APIs; they will be going away eventually.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@246985 91177308-0d34-0410-b5e6-96231b3b80d8
    f4ddf94e
    History
    Compute and preserve alignment more faithfully in IR-generation.
    John McCall authored
    Introduce an Address type to bundle a pointer value with an
    alignment.  Introduce APIs on CGBuilderTy to work with Address
    values.  Change core APIs on CGF/CGM to traffic in Address where
    appropriate.  Require alignments to be non-zero.  Update a ton
    of code to compute and propagate alignment information.
    
    As part of this, I've promoted CGBuiltin's EmitPointerWithAlignment
    helper function to CGF and made use of it in a number of places in
    the expression emitter.
    
    The end result is that we should now be significantly more correct
    when performing operations on objects that are locally known to
    be under-aligned.  Since alignment is not reliably tracked in the
    type system, there are inherent limits to this, but at least we
    are no longer confused by standard operations like derived-to-base
    conversions and array-to-pointer decay.  I've also fixed a large
    number of bugs where we were applying the complete-object alignment
    to a pointer instead of the non-virtual alignment, although most of
    these were hidden by the very conservative approach we took with
    member alignment.
    
    Also, because IRGen now reliably asserts on zero alignments, we
    should no longer be subject to an absurd but frustrating recurring
    bug where an incomplete type would report a zero alignment and then
    we'd naively do a alignmentAtOffset on it and emit code using an
    alignment equal to the largest power-of-two factor of the offset.
    
    We should also now be emitting much more aggressive alignment
    attributes in the presence of over-alignment.  In particular,
    field access now uses alignmentAtOffset instead of min.
    
    Several times in this patch, I had to change the existing
    code-generation pattern in order to more effectively use
    the Address APIs.  For the most part, this seems to be a strict
    improvement, like doing pointer arithmetic with GEPs instead of
    ptrtoint.  That said, I've tried very hard to not change semantics,
    but it is likely that I've failed in a few places, for which I
    apologize.
    
    ABIArgInfo now always carries the assumed alignment of indirect and
    indirect byval arguments.  In order to cut down on what was already
    a dauntingly large patch, I changed the code to never set align
    attributes in the IR on non-byval indirect arguments.  That is,
    we still generate code which assumes that indirect arguments have
    the given alignment, but we don't express this information to the
    backend except where it's semantically required (i.e. on byvals).
    This is likely a minor regression for those targets that did provide
    this information, but it'll be trivial to add it back in a later
    patch.
    
    I partially punted on applying this work to CGBuiltin.  Please
    do not add more uses of the CreateDefaultAligned{Load,Store}
    APIs; they will be going away eventually.
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@246985 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.