Skip to content
Snippets Groups Projects
  • Daniel Jasper's avatar
    23e46241
    [clang-format] Refactor WhitespaceManager and friends · 23e46241
    Daniel Jasper authored
    The main motivation behind this is to cleanup the WhitespaceManager and
    make it more extensible for future alignment etc. features.
    Specifically, WhitespaceManager has started to copy more and more code
    that is already present in FormatToken. Instead, I think it makes more
    sense to actually store a reference to each FormatToken for each change.
    
    This has as a consequence led to a change in the calculation of indent
    levels. Now, we actually compute them for each Token ahead of time,
    which should be more efficient as it removes an unsigned value for the
    ParenState, which is used during the combinatorial exploration of the
    solution space.
    
    No functional changes intended.
    
    Review: https://reviews.llvm.org/D29300
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@293616 91177308-0d34-0410-b5e6-96231b3b80d8
    23e46241
    History
    [clang-format] Refactor WhitespaceManager and friends
    Daniel Jasper authored
    The main motivation behind this is to cleanup the WhitespaceManager and
    make it more extensible for future alignment etc. features.
    Specifically, WhitespaceManager has started to copy more and more code
    that is already present in FormatToken. Instead, I think it makes more
    sense to actually store a reference to each FormatToken for each change.
    
    This has as a consequence led to a change in the calculation of indent
    levels. Now, we actually compute them for each Token ahead of time,
    which should be more efficient as it removes an unsigned value for the
    ParenState, which is used during the combinatorial exploration of the
    solution space.
    
    No functional changes intended.
    
    Review: https://reviews.llvm.org/D29300
    
    git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@293616 91177308-0d34-0410-b5e6-96231b3b80d8
Code owners
Assign users and groups as approvers for specific file changes. Learn more.