Default vaarg lowering should support indirect struct types.
Fixes PR11517 for SPARC. On most targets, clang lowers va_arg itself, eschewing the use of the llvm vaarg instruction. This is necessary (at least for now) as the type argument to the vaarg instruction cannot represent all the ABI information that is needed to support complex calling conventions. However, on targets with a simpler varrags ABIs, the LLVM instruction can work just fine, and clang can simply lower to it. Unfortunately, even on such targets, vaarg with a struct argument would fail, because the default lowering to vaarg was naive: it didn't take into account the ABI attribute computed by classifyArgumentType. In particular, for the DefaultABIInfo, structs are supposed to be passed indirectly and so llvm's vaarg instruction should be emitted with a pointer argument. Now, vaarg instruction emission is able to use computed ABIArgInfo for the provided argument type, which allows the default ABI support to work for structs too. I haven't touched the EmitVAArg implementation for PPC32_SVR4 or XCore, although I believe both are now redundant, and could be switched over to use the default implementation as well. Differential Revision: http://reviews.llvm.org/D16154 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@261717 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- lib/CodeGen/CGExprAgg.cpp 2 additions, 5 deletionslib/CodeGen/CGExprAgg.cpp
- lib/CodeGen/CGExprScalar.cpp 5 additions, 3 deletionslib/CodeGen/CGExprScalar.cpp
- lib/CodeGen/TargetInfo.cpp 68 additions, 12 deletionslib/CodeGen/TargetInfo.cpp
- test/CodeGen/le32-vaarg.c 6 additions, 2 deletionstest/CodeGen/le32-vaarg.c
- test/CodeGen/sparc-vaarg.c 35 additions, 0 deletionstest/CodeGen/sparc-vaarg.c
Loading
Please register or sign in to comment