Skip to content
Snippets Groups Projects
Commit 16618240 authored by Daniel Jasper's avatar Daniel Jasper
Browse files

Fix a bug where we would move a following line into a comment.

Before: Constructor() : a(a), // comment a(a) {}
After:  Constructor() : a(a), // comment
                        a(a) {}

Needed this as a quick fix. Will add more tests for this in a future
commit.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@172624 91177308-0d34-0410-b5e6-96231b3b80d8
parent 36845474
No related branches found
No related tags found
No related merge requests found
...@@ -492,7 +492,7 @@ private: ...@@ -492,7 +492,7 @@ private:
if (Previous.is(tok::l_paren) || Previous.is(tok::l_brace) || if (Previous.is(tok::l_paren) || Previous.is(tok::l_brace) ||
State.NextToken->Parent->Type == TT_TemplateOpener) State.NextToken->Parent->Type == TT_TemplateOpener)
State.Stack[ParenLevel].Indent = State.Column + Spaces; State.Stack[ParenLevel].Indent = State.Column + Spaces;
if (Previous.is(tok::comma)) if (Previous.is(tok::comma) && Current.Type != TT_LineComment)
State.Stack[ParenLevel].HasMultiParameterLine = true; State.Stack[ParenLevel].HasMultiParameterLine = true;
......
...@@ -746,6 +746,11 @@ TEST_F(FormatTest, ConstructorInitializers) { ...@@ -746,6 +746,11 @@ TEST_F(FormatTest, ConstructorInitializers) {
" : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
" aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
" aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}"); " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}");
verifyGoogleFormat(
"SomeClass::Constructor()\n"
" : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n"
" aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
" aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}");
verifyFormat( verifyFormat(
"SomeClass::Constructor()\n" "SomeClass::Constructor()\n"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment