Force a load when creating a reference to a temporary copied from a bitfield.
For this source: const int &ref = someStruct.bitfield; We used to generate this AST: DeclStmt [...] `-VarDecl [...] ref 'const int &' `-MaterializeTemporaryExpr [...] 'const int' lvalue `-ImplicitCastExpr [...] 'const int' lvalue <NoOp> `-MemberExpr [...] 'int' lvalue bitfield .bitfield [...] `-DeclRefExpr [...] 'struct X' lvalue ParmVar [...] 'someStruct' 'struct X' Notice the lvalue inside the MaterializeTemporaryExpr, which is very confusing (and caused an assertion to fire in the analyzer - PR15694). We now generate this: DeclStmt [...] `-VarDecl [...] ref 'const int &' `-MaterializeTemporaryExpr [...] 'const int' lvalue `-ImplicitCastExpr [...] 'int' <LValueToRValue> `-MemberExpr [...] 'int' lvalue bitfield .bitfield [...] `-DeclRefExpr [...] 'struct X' lvalue ParmVar [...] 'someStruct' 'struct X' Which makes a lot more sense. This allows us to remove code in both CodeGen and AST that hacked around this special case. The commit also makes Clang accept this (legal) C++11 code: int &&ref = std::move(someStruct).bitfield PR15694 / <rdar://problem/13600396> git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@179250 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- include/clang/Sema/Initialization.h 8 additions, 0 deletionsinclude/clang/Sema/Initialization.h
- lib/AST/ExprConstant.cpp 4 additions, 17 deletionslib/AST/ExprConstant.cpp
- lib/CodeGen/CGExpr.cpp 124 additions, 129 deletionslib/CodeGen/CGExpr.cpp
- lib/Sema/SemaInit.cpp 90 additions, 9 deletionslib/Sema/SemaInit.cpp
- test/Analysis/reference.cpp 10 additions, 0 deletionstest/Analysis/reference.cpp
- test/CXX/dcl.decl/dcl.init/dcl.init.ref/p5-0x.cpp 34 additions, 0 deletionstest/CXX/dcl.decl/dcl.init/dcl.init.ref/p5-0x.cpp
Loading
Please register or sign in to comment