[ubsan] Teach the pointer overflow check that "p - <unsigned> <= p" (PR33430)
The pointer overflow check gives false negatives when dealing with expressions in which an unsigned value is subtracted from a pointer. This is summarized in PR33430 [1]: ubsan permits the result of the subtraction to be greater than "p", but it should not. To fix the issue, we should track whether or not the pointer expression is a subtraction. If it is, and the indices are unsigned, we know to expect "p - <unsigned> <= p". I've tested this by running check-{llvm,clang} with a stage2 ubsan-enabled build. I've also added some tests to compiler-rt, which are in D34122. [1] https://bugs.llvm.org/show_bug.cgi?id=33430 Differential Revision: https://reviews.llvm.org/D34121 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@307955 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- lib/CodeGen/CGExpr.cpp 3 additions, 1 deletionlib/CodeGen/CGExpr.cpp
- lib/CodeGen/CGExprScalar.cpp 23 additions, 15 deletionslib/CodeGen/CGExprScalar.cpp
- lib/CodeGen/CodeGenFunction.h 7 additions, 0 deletionslib/CodeGen/CodeGenFunction.h
- test/CodeGen/ubsan-pointer-overflow.m 11 additions, 4 deletionstest/CodeGen/ubsan-pointer-overflow.m
Loading
Please register or sign in to comment