-
- Downloads
[analyzer] Add checker modeling gtest APIs.
gtest is a widely-used unit-testing API. It provides macros for unit test assertions: ASSERT_TRUE(p != nullptr); that expand into an if statement that constructs an object representing the result of the assertion and returns when the assertion is false: if (AssertionResult gtest_ar_ = AssertionResult(p == nullptr)) ; else return ...; Unfortunately, the analyzer does not model the effect of the constructor precisely because (1) the copy constructor implementation is missing from the the header (so it can't be inlined) and (2) the boolean-argument constructor is constructed into a temporary (so the analyzer decides not to inline it since it doesn't reliably call temporary destructors right now). This results in false positives because the analyzer does not realize that the the assertion must hold along the non-return path. This commit addresses the false positives by explicitly modeling the effects of the two un-inlined constructors on the AssertionResult state. I've added a new package, "apiModeling", for these kinds of checkers that model APIs but don't emit any diagnostics. I envision all the checkers in this package always being on by default. This addresses the false positives reported in PR30936. Differential Revision: https://reviews.llvm.org/D27773 rdar://problem/22705813 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@290143 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- include/clang/StaticAnalyzer/Checkers/Checkers.td 18 additions, 0 deletionsinclude/clang/StaticAnalyzer/Checkers/Checkers.td
- lib/Driver/Tools.cpp 1 addition, 0 deletionslib/Driver/Tools.cpp
- lib/StaticAnalyzer/Checkers/CMakeLists.txt 1 addition, 0 deletionslib/StaticAnalyzer/Checkers/CMakeLists.txt
- lib/StaticAnalyzer/Checkers/GTestChecker.cpp 287 additions, 0 deletionslib/StaticAnalyzer/Checkers/GTestChecker.cpp
- test/Analysis/gtest.cpp 142 additions, 0 deletionstest/Analysis/gtest.cpp
- test/Driver/analyzer-target-enabled-checkers.cpp 3 additions, 0 deletionstest/Driver/analyzer-target-enabled-checkers.cpp
Loading
Please register or sign in to comment