[ms-cxxabi] Emit linkonce complete dtors in TUs that need them
Based on Peter Collingbourne's destructor patches. Prior to this change, clang was considering ?1 to be the complete destructor and the base destructor, which was wrong. This lead to crashes when clang tried to emit two LLVM functions with the same name. In this ABI, TUs with non-inline dtors might not emit a complete destructor. They are emitted as inline thunks in TUs that need them, and they always delegate to the base dtors of the complete class and its virtual bases. This change uses the DeferredDecls machinery to emit complete dtors as needed. Currently in clang try body destructors can catch exceptions thrown by virtual base destructors. In the Microsoft C++ ABI, clang may not have the destructor definition, in which case clang won't wrap the virtual virtual base destructor calls in a try-catch. Diagnosing this in user code is TODO. Finally, for classes that don't use virtual inheritance, MSVC always calls the base destructor (?1) directly. This is a useful code size optimization that avoids emitting lots of extra thunks or aliases. Implementing it also means our existing tests continue to pass, and is consistent with MSVC's output. We can do the same for Itanium by tweaking GetAddrOfCXXDestructor, but it will require further testing. Reviewers: rjmccall CC: cfe-commits Differential Revision: http://llvm-reviews.chandlerc.com/D1066 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@186828 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- include/clang/Basic/TargetCXXABI.h 0 additions, 6 deletionsinclude/clang/Basic/TargetCXXABI.h
- lib/AST/MicrosoftMangle.cpp 14 additions, 13 deletionslib/AST/MicrosoftMangle.cpp
- lib/CodeGen/CGCXX.cpp 15 additions, 20 deletionslib/CodeGen/CGCXX.cpp
- lib/CodeGen/CGCXXABI.h 9 additions, 0 deletionslib/CodeGen/CGCXXABI.h
- lib/CodeGen/CGClass.cpp 8 additions, 3 deletionslib/CodeGen/CGClass.cpp
- lib/CodeGen/CGExprCXX.cpp 2 additions, 2 deletionslib/CodeGen/CGExprCXX.cpp
- lib/CodeGen/CodeGenModule.cpp 15 additions, 1 deletionlib/CodeGen/CodeGenModule.cpp
- lib/CodeGen/CodeGenModule.h 6 additions, 9 deletionslib/CodeGen/CodeGenModule.h
- lib/CodeGen/ItaniumCXXABI.cpp 26 additions, 0 deletionslib/CodeGen/ItaniumCXXABI.cpp
- lib/CodeGen/MicrosoftCXXABI.cpp 47 additions, 1 deletionlib/CodeGen/MicrosoftCXXABI.cpp
- test/CodeGenCXX/microsoft-abi-structors.cpp 65 additions, 14 deletionstest/CodeGenCXX/microsoft-abi-structors.cpp
Loading
Please register or sign in to comment