Skip to content
Snippets Groups Projects
Commit a54d1876 authored by Roman Lebedev's avatar Roman Lebedev
Browse files

[Sema] Document+test the -Wsign-conversion change for enums in C code [NFC]

Basically a regression after r316268.
However the diagnostic is correct, but the test coverage is bad.

So just like rL316500, introduce yet more tests,
and adjust the release notes.

See https://bugs.llvm.org/show_bug.cgi?id=35200

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@317421 91177308-0d34-0410-b5e6-96231b3b80d8
parent 0576e32f
No related branches found
No related tags found
No related merge requests found
......@@ -82,7 +82,8 @@ Improvements to Clang's diagnostics
tautological comparisons between integer variable of the type ``T`` and the
largest/smallest possible integer constant of that same type.
- For C code, ``-Wsign-compare``, ``-Wtautological-constant-compare`` and
- For C code, ``-Wsign-compare``, ``-Wsign-conversion``,
``-Wtautological-constant-compare`` and
``-Wtautological-constant-out-of-range-compare`` were adjusted to use the
underlying datatype of ``enum``.
......
// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -fsyntax-only -verify -DUNSIGNED -Wsign-conversion %s
// RUN: %clang_cc1 -triple=x86_64-pc-win32 -fsyntax-only -verify -Wsign-conversion %s
// PR35200
enum X { A,B,C};
int f(enum X x) {
#ifdef UNSIGNED
return x; // expected-warning {{implicit conversion changes signedness: 'enum X' to 'int'}}
#else
// expected-no-diagnostics
return x;
#endif
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment