Function with unparsed body is a definition
While a function body is being parsed, the function declaration is not considered as a definition because it does not have a body yet. In some cases it leads to incorrect interpretation, the case is presented in https://bugs.llvm.org/show_bug.cgi?id=14785: ``` template<typename T> struct Somewhat { void internal() const {} friend void operator+(int const &, Somewhat<T> const &) {} }; void operator+(int const &, Somewhat<char> const &x) { x.internal(); } ``` When statement `x.internal()` in the body of global `operator+` is parsed, the type of `x` must be completed, so the instantiation of `Somewhat<char>` is started. It instantiates the declaration of `operator+` defined inline, and makes a check for redefinition. The check does not detect another definition because the declaration of `operator+` is still not defining as does not have a body yet. To solves this problem the function `isThisDeclarationADefinition` considers a function declaration as a definition if it has flag `WillHaveBody` set. This change fixes PR14785. Differential Revision: https://reviews.llvm.org/D30375 This is a recommit of 305379, reverted in 305381, with small changes. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@305903 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- include/clang/AST/Decl.h 1 addition, 1 deletioninclude/clang/AST/Decl.h
- lib/Sema/SemaCUDA.cpp 0 additions, 6 deletionslib/Sema/SemaCUDA.cpp
- lib/Sema/SemaDecl.cpp 1 addition, 0 deletionslib/Sema/SemaDecl.cpp
- lib/Sema/SemaDeclCXX.cpp 3 additions, 0 deletionslib/Sema/SemaDeclCXX.cpp
- lib/Sema/SemaTemplateInstantiateDecl.cpp 3 additions, 0 deletionslib/Sema/SemaTemplateInstantiateDecl.cpp
- test/SemaCXX/friend2.cpp 37 additions, 0 deletionstest/SemaCXX/friend2.cpp
Loading
Please register or sign in to comment