Reapply fixed "Honour 'use-external-names' in FileManager"
Was r202442 There were two issues with the original patch that have now been fixed. 1. We were memset'ing over a FileEntry in a test case. After adding a std::string to FileEntry, this still happened to not break for me. 2. I didn't pass the FileManager into the new compiler instance in compileModule. This was hidden in some cases by the fact I didn't clear the module cache in the test. Also, I changed the copy constructor for FileEntry, which was memcpy'ing in a (now) unsafe way. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@202539 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- include/clang/Basic/FileManager.h 7 additions, 6 deletionsinclude/clang/Basic/FileManager.h
- include/clang/Basic/FileSystemStatCache.h 2 additions, 0 deletionsinclude/clang/Basic/FileSystemStatCache.h
- include/clang/Basic/VirtualFileSystem.h 2 additions, 0 deletionsinclude/clang/Basic/VirtualFileSystem.h
- lib/Basic/FileManager.cpp 1 addition, 1 deletionlib/Basic/FileManager.cpp
- lib/Basic/FileSystemStatCache.cpp 1 addition, 0 deletionslib/Basic/FileSystemStatCache.cpp
- lib/Basic/VirtualFileSystem.cpp 29 additions, 8 deletionslib/Basic/VirtualFileSystem.cpp
- lib/Frontend/CompilerInstance.cpp 1 addition, 1 deletionlib/Frontend/CompilerInstance.cpp
- lib/Lex/PTHLexer.cpp 1 addition, 0 deletionslib/Lex/PTHLexer.cpp
- test/VFS/Inputs/external-names.h 4 additions, 0 deletionstest/VFS/Inputs/external-names.h
- test/VFS/Inputs/use-external-names.yaml 7 additions, 0 deletionstest/VFS/Inputs/use-external-names.yaml
- test/VFS/external-names.c 35 additions, 0 deletionstest/VFS/external-names.c
- test/VFS/module-import.m 1 addition, 0 deletionstest/VFS/module-import.m
- unittests/Basic/FileManagerTest.cpp 6 additions, 3 deletionsunittests/Basic/FileManagerTest.cpp
Loading
Please register or sign in to comment