-
- Downloads
Revert r309106 "Recommit r308327 2nd time: Add a warning for missing"
The warning fires on non-suspicious code in Chromium. Reverting until a solution is figured out. > Recommit r308327 2nd time: Add a warning for missing > '#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files > > The first recommit (r308441) caused a "non-default #pragma pack value might > change the alignment of struct or union members in the included file" warning > in LLVM itself. This recommit tweaks the added warning to avoid warnings for > #includes that don't have any records that are affected by the non-default > alignment. This tweak avoids the previously emitted warning in LLVM. > > Original message: > > This commit adds a new -Wpragma-pack warning. It warns in the following cases: > > - When a translation unit is missing terminating #pragma pack (pop) directives. > - When entering an included file if the current alignment value as determined > by '#pragma pack' directives is different from the default alignment value. > - When leaving an included file that changed the state of the current alignment > value. > > rdar://10184173 > > Differential Revision: https://reviews.llvm.org/D35484 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@309186 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- include/clang/Basic/DiagnosticGroups.td 1 addition, 2 deletionsinclude/clang/Basic/DiagnosticGroups.td
- include/clang/Basic/DiagnosticSemaKinds.td 0 additions, 10 deletionsinclude/clang/Basic/DiagnosticSemaKinds.td
- include/clang/Lex/PPCallbacks.h 0 additions, 6 deletionsinclude/clang/Lex/PPCallbacks.h
- include/clang/Sema/Sema.h 5 additions, 31 deletionsinclude/clang/Sema/Sema.h
- include/clang/Serialization/ASTReader.h 0 additions, 1 deletioninclude/clang/Serialization/ASTReader.h
- lib/Parse/ParsePragma.cpp 2 additions, 7 deletionslib/Parse/ParsePragma.cpp
- lib/Sema/Sema.cpp 0 additions, 54 deletionslib/Sema/Sema.cpp
- lib/Sema/SemaAttr.cpp 1 addition, 54 deletionslib/Sema/SemaAttr.cpp
- lib/Serialization/ASTReader.cpp 2 additions, 4 deletionslib/Serialization/ASTReader.cpp
- lib/Serialization/ASTWriter.cpp 0 additions, 1 deletionlib/Serialization/ASTWriter.cpp
- test/OpenMP/declare_simd_messages.cpp 1 addition, 1 deletiontest/OpenMP/declare_simd_messages.cpp
- test/PCH/pragma-pack.c 15 additions, 15 deletionstest/PCH/pragma-pack.c
- test/PCH/suspicious-pragma-pack.c 0 additions, 8 deletionstest/PCH/suspicious-pragma-pack.c
- test/Parser/pragma-options.c 1 addition, 1 deletiontest/Parser/pragma-options.c
- test/Parser/pragma-options.cpp 1 addition, 1 deletiontest/Parser/pragma-options.cpp
- test/Parser/pragma-pack.c 1 addition, 1 deletiontest/Parser/pragma-pack.c
- test/Sema/Inputs/pragma-pack1.h 0 additions, 27 deletionstest/Sema/Inputs/pragma-pack1.h
- test/Sema/Inputs/pragma-pack2.h 0 additions, 8 deletionstest/Sema/Inputs/pragma-pack2.h
- test/Sema/pragma-pack.c 0 additions, 5 deletionstest/Sema/pragma-pack.c
- test/Sema/suspicious-pragma-pack.c 0 additions, 49 deletionstest/Sema/suspicious-pragma-pack.c
Loading
Please register or sign in to comment