Make DiagnosticsEngine::takeClient return std::unique_ptr<>
Summary: Make DiagnosticsEngine::takeClient return std::unique_ptr<>. Updated callers to store conditional ownership using a pair of pointer and unique_ptr instead of a pointer + bool. Updated code that temporarily registers clients to use the non-owning registration (+ removed extra calls to takeClient). Reviewers: dblaikie Reviewed By: dblaikie Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D6294 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@222193 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- include/clang/Basic/Diagnostic.h 4 additions, 8 deletionsinclude/clang/Basic/Diagnostic.h
- include/clang/Frontend/VerifyDiagnosticConsumer.h 1 addition, 1 deletioninclude/clang/Frontend/VerifyDiagnosticConsumer.h
- include/clang/Rewrite/Frontend/FixItRewriter.h 1 addition, 1 deletioninclude/clang/Rewrite/Frontend/FixItRewriter.h
- lib/Basic/Diagnostic.cpp 5 additions, 15 deletionslib/Basic/Diagnostic.cpp
- lib/Frontend/ASTUnit.cpp 6 additions, 6 deletionslib/Frontend/ASTUnit.cpp
- lib/Frontend/CompilerInstance.cpp 3 additions, 5 deletionslib/Frontend/CompilerInstance.cpp
- lib/Frontend/Rewrite/FixItRewriter.cpp 6 additions, 9 deletionslib/Frontend/Rewrite/FixItRewriter.cpp
- lib/Frontend/VerifyDiagnosticConsumer.cpp 6 additions, 10 deletionslib/Frontend/VerifyDiagnosticConsumer.cpp
- tools/driver/driver.cpp 1 addition, 2 deletionstools/driver/driver.cpp
- unittests/Sema/ExternalSemaSourceTest.cpp 1 addition, 1 deletionunittests/Sema/ExternalSemaSourceTest.cpp
Loading
Please register or sign in to comment