Skip to content
Snippets Groups Projects
  1. Dec 31, 2016
  2. Dec 30, 2016
  3. Dec 29, 2016
    • Kelvin Li's avatar
      [OpenMP] Sema and parsing for 'target teams distribute parallel for’ pragma · 1008244c
      Kelvin Li authored
      This patch is to implement sema and parsing for 'target teams distribute parallel for’ pragma.
      
      Differential Revision: https://reviews.llvm.org/D28160
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@290725 91177308-0d34-0410-b5e6-96231b3b80d8
      1008244c
    • Justin Lebar's avatar
      [ADT] Delete RefCountedBaseVPTR. · a7c050e2
      Justin Lebar authored
      Summary:
      This class is unnecessary.
      
      Its comment indicated that it was a compile error to allocate an
      instance of a class that inherits from RefCountedBaseVPTR on the stack.
      This may have been true at one point, but it's not today.
      
      Moreover you really do not want to allocate *any* refcounted object on
      the stack, vptrs or not, so if we did have a way to prevent these
      objects from being stack-allocated, we'd want to apply it to regular
      RefCountedBase too, obviating the need for a separate RefCountedBaseVPTR
      class.
      
      It seems that the main way RefCountedBaseVPTR provides safety is by
      making its subclass's destructor virtual.  This may have been helpful at
      one point, but these days clang will emit an error if you define a class
      with virtual functions that inherits from RefCountedBase but doesn't
      have a virtual destructor.
      
      Reviewers: compnerd, dblaikie
      
      Subscribers: cfe-commits, klimek, llvm-commits, mgorny
      
      Differential Revision: https://reviews.llvm.org/D28162
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@290717 91177308-0d34-0410-b5e6-96231b3b80d8
      a7c050e2
  4. Dec 28, 2016
  5. Dec 27, 2016
Loading