Skip to content
Snippets Groups Projects
  1. Feb 27, 2018
  2. Feb 23, 2018
  3. Feb 22, 2018
  4. Feb 21, 2018
  5. Feb 20, 2018
    • Hans Wennborg's avatar
      Merging r325576: · ae798ac3
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r325576 | hans | 2018-02-20 13:43:02 +0100 (Tue, 20 Feb 2018) | 13 lines
      
      Revert r325375 "[MS] Make constexpr static data members implicitly inline"
      
      This broke Clang bootstrap on Windows, PR36453.
      
      > This handles them exactly the same way that we handle const integral
      > static data members with inline definitions, which is what MSVC does.
      >
      > As a follow-up, now that we have a way to mark variables inline in the
      > AST, we should consider marking them implicitly inline there instead of
      > only treating them as inline in CodeGen. Unfortunately, this breaks a
      > lot of dllimport test cases, so that is future work for now.
      >
      > Fixes PR36125.
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@325577 91177308-0d34-0410-b5e6-96231b3b80d8
      ae798ac3
  6. Feb 19, 2018
    • Hans Wennborg's avatar
      Merging r325375: · d535c749
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r325375 | rnk | 2018-02-16 20:44:47 +0100 (Fri, 16 Feb 2018) | 11 lines
      
      [MS] Make constexpr static data members implicitly inline
      
      This handles them exactly the same way that we handle const integral
      static data members with inline definitions, which is what MSVC does.
      
      As a follow-up, now that we have a way to mark variables inline in the
      AST, we should consider marking them implicitly inline there instead of
      only treating them as inline in CodeGen. Unfortunately, this breaks a
      lot of dllimport test cases, so that is future work for now.
      
      Fixes PR36125.
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@325500 91177308-0d34-0410-b5e6-96231b3b80d8
      d535c749
  7. Feb 14, 2018
  8. Feb 09, 2018
    • Hans Wennborg's avatar
      Merging r324537: · 4a005620
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r324537 | rsmith | 2018-02-07 23:25:16 +0100 (Wed, 07 Feb 2018) | 14 lines
      
      PR36055: fix computation of *-dependence in nested initializer lists.
      
      When we synthesize an implicit inner initializer list when analyzing an outer
      initializer list, we add it to the outer list immediately, and then fill in the
      inner list. This gives the outer list no chance to update its *-dependence bits
      with those of the completed inner list. To fix this, re-add the inner list to
      the outer list once it's completed.
      
      Note that we do not recompute the *-dependence bits from scratch when we
      complete an outer list; this would give the wrong result for the case where a
      designated initializer overwrites a dependent initializer with a non-dependent
      one. The resulting list in that case should still be dependent, even though all
      traces of the dependence were removed from the semantic form.
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324719 91177308-0d34-0410-b5e6-96231b3b80d8
      4a005620
    • Hans Wennborg's avatar
      Merging r324594: · 1d5b6bd0
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r324594 | aivchenk | 2018-02-08 12:15:21 +0100 (Thu, 08 Feb 2018) | 17 lines
      
      Fix for #31362 - ms_abi is implemented incorrectly for values >=16 bytes.
      
      Summary:
      This patch is a fix for following issue:
      https://bugs.llvm.org/show_bug.cgi?id=31362 The problem was caused by front end
      lowering C calling conventions without taking into account calling conventions
      enforced by attribute. In this case win64cc was no correctly lowered on targets
      other than Windows.
      
      Reviewed By: rnk (Reid Kleckner)
      
      Differential Revision: https://reviews.llvm.org/D43016
      
      Author: belickim <mateusz.belicki@intel.com>
      
      
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324718 91177308-0d34-0410-b5e6-96231b3b80d8
      1d5b6bd0
  9. Feb 08, 2018
    • Hans Wennborg's avatar
      Merging r324514: · 9524f2cc
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r324514 | arphaman | 2018-02-07 21:45:39 +0100 (Wed, 07 Feb 2018) | 10 lines
      
      [PR36008] Avoid -Wsign-compare warning for enum constants in
      typeof expressions
      
      This commit looks through typeof type at the original expression when diagnosing
      -Wsign-compare to avoid an unfriendly diagnostic.
      
      rdar://36588828
      
      Differential Revision: https://reviews.llvm.org/D42561
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324602 91177308-0d34-0410-b5e6-96231b3b80d8
      9524f2cc
    • Hans Wennborg's avatar
      Merging r324419: · 39e7ed25
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r324419 | vsapsai | 2018-02-06 23:39:25 +0100 (Tue, 06 Feb 2018) | 23 lines
      
      [Lex] Fix handling numerical literals ending with ' and signed exponent.
      
      For input `0'e+1` lexer tokenized as numeric constant only `0'e`. Later
      NumericLiteralParser skipped 0 and ' as digits and parsed `e+1` as valid
      exponent going past the end of the token. Because it didn't mark numeric
      literal as having an error, it continued parsing and tried to expandUCNs
      with StringRef of length -2.
      
      The fix is not to parse exponent when we reached the end of token.
      
      Discovered by OSS-Fuzz:
      https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4588
      
      rdar://problem/36076719
      
      Reviewers: rsmith, t.p.northover
      
      Reviewed By: rsmith
      
      Subscribers: cfe-commits, jkorous-apple
      
      Differential Revision: https://reviews.llvm.org/D41834
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324579 91177308-0d34-0410-b5e6-96231b3b80d8
      39e7ed25
  10. Feb 07, 2018
    • Hans Wennborg's avatar
      Merging r324439: · b010081f
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r324439 | compnerd | 2018-02-07 02:55:08 +0100 (Wed, 07 Feb 2018) | 5 lines
      
      AST: support SwiftCC on MS ABI
      
      Microsoft has reserved the identifier 'S' as the swift calling
      convention.  Decorate the symbols appropriately.  This enables swift on
      Windows.
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324460 91177308-0d34-0410-b5e6-96231b3b80d8
      b010081f
  11. Feb 06, 2018
    • Hans Wennborg's avatar
      Merging r324246: · 11cd7cef
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r324246 | mzeren-vmw | 2018-02-05 16:59:00 +0100 (Mon, 05 Feb 2018) | 33 lines
      
      [clang-format] Re-land: Fixup #include guard indents after parseFile()
      
      Summary:
      When a preprocessor indent closes after the last line of normal code we do not
      correctly fixup include guard indents. For example:
      
        #ifndef HEADER_H
        #define HEADER_H
        #if 1
        int i;
        #  define A 0
        #endif
        #endif
      
      incorrectly reformats to:
      
        #ifndef HEADER_H
        #define HEADER_H
        #if 1
        int i;
        #    define A 0
        #  endif
        #endif
      
      To resolve this issue we must fixup levels after parseFile(). Delaying
      the fixup introduces a new state, so consolidate include guard search
      state into an enum.
      
      Reviewers: krasimir, klimek
      
      Subscribers: cfe-commits
      
      Differential Revision: https://reviews.llvm.org/D42035
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324331 91177308-0d34-0410-b5e6-96231b3b80d8
      11cd7cef
    • Hans Wennborg's avatar
      Merging r323904: · 51390c59
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r323904 | mzeren-vmw | 2018-01-31 21:05:50 +0100 (Wed, 31 Jan 2018) | 34 lines
      
      [clang-format] Align preprocessor comments with #
      
      Summary:
      r312125, which introduced preprocessor indentation, shipped with a known
      issue where "indentation of comments immediately before indented
      preprocessor lines is toggled on each run". For example these two forms
      toggle:
      
        #ifndef HEADER_H
        #define HEADER_H
        #if 1
        // comment
        #   define A 0
        #endif
        #endif
      
        #ifndef HEADER_H
        #define HEADER_H
        #if 1
           // comment
        #   define A 0
        #endif
        #endif
      
      This happens because we check vertical alignment against the '#' yet
      indent to the level of the 'define'. This patch resolves this issue by
      aligning against the '#'.
      
      Reviewers: krasimir, klimek, djasper
      
      Reviewed By: krasimir
      
      Subscribers: cfe-commits
      Differential Revision: https://reviews.llvm.org/D42408
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324329 91177308-0d34-0410-b5e6-96231b3b80d8
      51390c59
  12. Feb 05, 2018
    • Hans Wennborg's avatar
      Merging r324059: · 1bfd05a5
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r324059 | mstorsjo | 2018-02-02 07:22:35 +0100 (Fri, 02 Feb 2018) | 21 lines
      
      [MinGW] Emit typeinfo locally for dllimported classes without key functions
      
      This fixes building Qt as shared libraries with clang in MinGW
      mode; previously subclasses of the QObjectData class (in other
      DLLs than the base DLL) failed to find the typeinfo symbols
      (that neither were emitted in the base DLL nor in the DLL
      containing the subclass).
      
      If the virtual destructor in the newly added testcase wouldn't
      be pure (or if there'd be another non-pure virtual method),
      it'd be a key function and things would work out even before this
      change. Make sure to locally emit the typeinfo for these classes
      as well.
      
      This matches what GCC does in this specific testcase.
      
      This fixes the root issue that spawned PR35146. (The difference
      to GCC that is initially described in that bug still is present
      though.)
      
      Differential Revision: https://reviews.llvm.org/D42641
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324219 91177308-0d34-0410-b5e6-96231b3b80d8
      1bfd05a5
    • Hans Wennborg's avatar
      Merging r323935: · eb51f1dc
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r323935 | rsmith | 2018-02-01 01:28:36 +0100 (Thu, 01 Feb 2018) | 5 lines
      
      PR36181: Teach CodeGen to properly ignore requests to emit dependent entities.
      
      Previously, friend function definitions within class templates slipped through
      the gaps and caused the MS mangler to assert.
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324215 91177308-0d34-0410-b5e6-96231b3b80d8
      eb51f1dc
    • Hans Wennborg's avatar
      Merging r324134: · 2f7bb0ce
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r324134 | ericwf | 2018-02-02 21:30:39 +0100 (Fri, 02 Feb 2018) | 14 lines
      
      Make __has_unique_object_representations reject empty union types.
      
      Summary:
      Clang incorrectly reports empty unions as having a unique object representation. However, this is not correct since `sizeof(EmptyUnion) == 1` AKA it has 8 bits of padding. Therefore it should be treated the same as an empty struct and report `false`.
      
      @erichkeane also suggested this fix should be merged into the 6.0 release branch, so the initial release of `__has_unique_object_representations` is as bug-free as possible. 
      
      Reviewers: erichkeane, rsmith, aaron.ballman, majnemer
      
      Reviewed By: erichkeane
      
      Subscribers: cfe-commits, erichkeane
      
      Differential Revision: https://reviews.llvm.org/D42863
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324213 91177308-0d34-0410-b5e6-96231b3b80d8
      2f7bb0ce
    • Hans Wennborg's avatar
      [ReleaseNotes] Add note for the new -fexperimental-isel flag. · 2e5d63f3
      Hans Wennborg authored
      Patch by Amara Emerson.
      
      Differential Revision: https://reviews.llvm.org/D42860
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324212 91177308-0d34-0410-b5e6-96231b3b80d8
      2e5d63f3
  13. Feb 02, 2018
    • Hans Wennborg's avatar
      Merging r323155: · 9c57ee8b
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r323155 | chandlerc | 2018-01-22 23:05:25 +0100 (Mon, 22 Jan 2018) | 133 lines
      
      Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injection", and is one of the two halves to Spectre..
      
      Summary:
      First, we need to explain the core of the vulnerability. Note that this
      is a very incomplete description, please see the Project Zero blog post
      for details:
      https://googleprojectzero.blogspot.com/2018/01/reading-privileged-memory-with-side.html
      
      The basis for branch target injection is to direct speculative execution
      of the processor to some "gadget" of executable code by poisoning the
      prediction of indirect branches with the address of that gadget. The
      gadget in turn contains an operation that provides a side channel for
      reading data. Most commonly, this will look like a load of secret data
      followed by a branch on the loaded value and then a load of some
      predictable cache line. The attacker then uses timing of the processors
      cache to determine which direction the branch took *in the speculative
      execution*, and in turn what one bit of the loaded value was. Due to the
      nature of these timing side channels and the branch predictor on Intel
      processors, this allows an attacker to leak data only accessible to
      a privileged domain (like the kernel) back into an unprivileged domain.
      
      The goal is simple: avoid generating code which contains an indirect
      branch that could have its prediction poisoned by an attacker. In many
      cases, the compiler can simply use directed conditional branches and
      a small search tree. LLVM already has support for lowering switches in
      this way and the first step of this patch is to disable jump-table
      lowering of switches and introduce a pass to rewrite explicit indirectbr
      sequences into a switch over integers.
      
      However, there is no fully general alternative to indirect calls. We
      introduce a new construct we call a "retpoline" to implement indirect
      calls in a non-speculatable way. It can be thought of loosely as
      a trampoline for indirect calls which uses the RET instruction on x86.
      Further, we arrange for a specific call->ret sequence which ensures the
      processor predicts the return to go to a controlled, known location. The
      retpoline then "smashes" the return address pushed onto the stack by the
      call with the desired target of the original indirect call. The result
      is a predicted return to the next instruction after a call (which can be
      used to trap speculative execution within an infinite loop) and an
      actual indirect branch to an arbitrary address.
      
      On 64-bit x86 ABIs, this is especially easily done in the compiler by
      using a guaranteed scratch register to pass the target into this device.
      For 32-bit ABIs there isn't a guaranteed scratch register and so several
      different retpoline variants are introduced to use a scratch register if
      one is available in the calling convention and to otherwise use direct
      stack push/pop sequences to pass the target address.
      
      This "retpoline" mitigation is fully described in the following blog
      post: https://support.google.com/faqs/answer/7625886
      
      We also support a target feature that disables emission of the retpoline
      thunk by the compiler to allow for custom thunks if users want them.
      These are particularly useful in environments like kernels that
      routinely do hot-patching on boot and want to hot-patch their thunk to
      different code sequences. They can write this custom thunk and use
      `-mretpoline-external-thunk` *in addition* to `-mretpoline`. In this
      case, on x86-64 thu thunk names must be:
      ```
        __llvm_external_retpoline_r11
      ```
      or on 32-bit:
      ```
        __llvm_external_retpoline_eax
        __llvm_external_retpoline_ecx
        __llvm_external_retpoline_edx
        __llvm_external_retpoline_push
      ```
      And the target of the retpoline is passed in the named register, or in
      the case of the `push` suffix on the top of the stack via a `pushl`
      instruction.
      
      There is one other important source of indirect branches in x86 ELF
      binaries: the PLT. These patches also include support for LLD to
      generate PLT entries that perform a retpoline-style indirection.
      
      The only other indirect branches remaining that we are aware of are from
      precompiled runtimes (such as crt0.o and similar). The ones we have
      found are not really attackable, and so we have not focused on them
      here, but eventually these runtimes should also be replicated for
      retpoline-ed configurations for completeness.
      
      For kernels or other freestanding or fully static executables, the
      compiler switch `-mretpoline` is sufficient to fully mitigate this
      particular attack. For dynamic executables, you must compile *all*
      libraries with `-mretpoline` and additionally link the dynamic
      executable and all shared libraries with LLD and pass `-z retpolineplt`
      (or use similar functionality from some other linker). We strongly
      recommend also using `-z now` as non-lazy binding allows the
      retpoline-mitigated PLT to be substantially smaller.
      
      When manually apply similar transformations to `-mretpoline` to the
      Linux kernel we observed very small performance hits to applications
      running typical workloads, and relatively minor hits (approximately 2%)
      even for extremely syscall-heavy applications. This is largely due to
      the small number of indirect branches that occur in performance
      sensitive paths of the kernel.
      
      When using these patches on statically linked applications, especially
      C++ applications, you should expect to see a much more dramatic
      performance hit. For microbenchmarks that are switch, indirect-, or
      virtual-call heavy we have seen overheads ranging from 10% to 50%.
      
      However, real-world workloads exhibit substantially lower performance
      impact. Notably, techniques such as PGO and ThinLTO dramatically reduce
      the impact of hot indirect calls (by speculatively promoting them to
      direct calls) and allow optimized search trees to be used to lower
      switches. If you need to deploy these techniques in C++ applications, we
      *strongly* recommend that you ensure all hot call targets are statically
      linked (avoiding PLT indirection) and use both PGO and ThinLTO. Well
      tuned servers using all of these techniques saw 5% - 10% overhead from
      the use of retpoline.
      
      We will add detailed documentation covering these components in
      subsequent patches, but wanted to make the core functionality available
      as soon as possible. Happy for more code review, but we'd really like to
      get these patches landed and backported ASAP for obvious reasons. We're
      planning to backport this to both 6.0 and 5.0 release streams and get
      a 5.0 release with just this cherry picked ASAP for distros and vendors.
      
      This patch is the work of a number of people over the past month: Eric, Reid,
      Rui, and myself. I'm mailing it out as a single commit due to the time
      sensitive nature of landing this and the need to backport it. Huge thanks to
      everyone who helped out here, and everyone at Intel who helped out in
      discussions about how to craft this. Also, credit goes to Paul Turner (at
      Google, but not an LLVM contributor) for much of the underlying retpoline
      design.
      
      Reviewers: echristo, rnk, ruiu, craig.topper, DavidKreitzer
      
      Subscribers: sanjoy, emaste, mcrosier, mgorny, mehdi_amini, hiraditya, llvm-commits
      
      Differential Revision: https://reviews.llvm.org/D41723
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@324068 91177308-0d34-0410-b5e6-96231b3b80d8
      9c57ee8b
  14. Jan 31, 2018
  15. Jan 30, 2018
    • Hans Wennborg's avatar
      Merging r323360: · ecdeea34
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r323360 | kparzysz | 2018-01-24 19:42:19 +0100 (Wed, 24 Jan 2018) | 2 lines
      
      [Hexagon] Accept lowercase b in -hvx-length=64b and -hvx-length=128b
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@323769 91177308-0d34-0410-b5e6-96231b3b80d8
      ecdeea34
    • Hans Wennborg's avatar
      Merging r323485: · b3a6ebf0
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r323485 | aemerson | 2018-01-26 01:27:22 +0100 (Fri, 26 Jan 2018) | 3 lines
      
      [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel.
      
      Differential Revision: https://reviews.llvm.org/D42276
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@323745 91177308-0d34-0410-b5e6-96231b3b80d8
      b3a6ebf0
    • Hans Wennborg's avatar
      Merging r322245: · f685e442
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r322245 | ctopper | 2018-01-11 02:37:59 +0100 (Thu, 11 Jan 2018) | 5 lines
      
      [X86] Make -mavx512f imply -mfma and -mf16c in the frontend like it does in the backend.
      
      Similarly, make -mno-fma and -mno-f16c imply -mno-avx512f.
      
      Withou this  "-mno-sse -mavx512f" ends up with avx512f being enabled in the frontend but disabled in the backend.
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@323741 91177308-0d34-0410-b5e6-96231b3b80d8
      f685e442
  16. Jan 24, 2018
    • Hans Wennborg's avatar
      Merging r323008: · abf562a4
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r323008 | vsapsai | 2018-01-20 00:41:47 +0100 (Sat, 20 Jan 2018) | 32 lines
      
      [Lex] Fix crash on code completion in comment in included file.
      
      This fixes PR32732 by updating CurLexerKind to reflect available lexers.
      We were hitting null pointer in Preprocessor::Lex because CurLexerKind
      was CLK_Lexer but CurLexer was null. And we set it to null in
      Preprocessor::HandleEndOfFile when exiting a file with code completion
      point.
      
      To reproduce the crash it is important for a comment to be inside a
      class specifier. In this case in Parser::ParseClassSpecifier we improve
      error recovery by pushing a semicolon token back into the preprocessor
      and later on try to lex a token because we haven't reached the end of
      file.
      
      Also clang crashes only on code completion in included file, i.e. when
      IncludeMacroStack is not empty. Though we reset CurLexer even if include
      stack is empty. The difference is that during pushing back a semicolon
      token, preprocessor calls EnterCachingLexMode which decides it is
      already in caching mode because various lexers are null and
      IncludeMacroStack is not empty. As the result, CurLexerKind remains
      CLK_Lexer instead of updating to CLK_CachingLexer.
      
      rdar://problem/34787685
      
      Reviewers: akyrtzi, doug.gregor, arphaman
      
      Reviewed By: arphaman
      
      Subscribers: cfe-commits, kfunk, arphaman, nemanjai, kbarton
      
      Differential Revision: https://reviews.llvm.org/D41688
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@323333 91177308-0d34-0410-b5e6-96231b3b80d8
      abf562a4
  17. Jan 23, 2018
  18. Jan 22, 2018
    • Serge Pavlov's avatar
      99f96ed7
    • Jonas Hahnfeld's avatar
      Merging r323123: · dfc3f2b2
      Jonas Hahnfeld authored
      ------------------------------------------------------------------------
      r323123 | hahnfeld | 2018-01-22 16:27:45 +0100 (Mon, 22 Jan 2018) | 6 lines
      
      [DOCS] Mention OpenMP Tools Interface in runtime library
      
      Also list supported configurations (architectures + operating
      systems).
      
      Differential Revision: https://reviews.llvm.org/D42349
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@323128 91177308-0d34-0410-b5e6-96231b3b80d8
      dfc3f2b2
    • Hans Wennborg's avatar
      Merging r322904 and r322905: · c4af92bc
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r322904 | rnk | 2018-01-18 23:55:14 +0100 (Thu, 18 Jan 2018) | 3 lines
      
      [CodeView] Sink complex inline functions to .cpp file, NFC
      
      I'm cleaning up this code before I attempt to fix a line table bug.
      ------------------------------------------------------------------------
      
      ------------------------------------------------------------------------
      r322905 | rnk | 2018-01-18 23:55:43 +0100 (Thu, 18 Jan 2018) | 5 lines
      
      [CodeView] Add line numbers for inlined call sites
      
      We did this for inline call site line tables, but we hadn't done it for
      regular function line tables yet. This patch copies that logic from
      encodeInlineLineTable.
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@323117 91177308-0d34-0410-b5e6-96231b3b80d8
      c4af92bc
    • Hans Wennborg's avatar
      Merging r322813: · 462588bf
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r322813 | rtrieu | 2018-01-18 05:28:56 +0100 (Thu, 18 Jan 2018) | 7 lines
      
      Fix Scope::dump()
      
      The dump function for Scope only has 20 out of the 24 flags.  Since it looped
      until no flags were left, having an unknown flag lead to an infinite loop.
      That loop has been changed to a single pass for each flag, plus an assert to
      alert if new flags are added.
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@323109 91177308-0d34-0410-b5e6-96231b3b80d8
      462588bf
    • Hans Wennborg's avatar
      Merging r322984: · 8231d605
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r322984 | rtrieu | 2018-01-19 21:46:19 +0100 (Fri, 19 Jan 2018) | 7 lines
      
      Allow BlockDecl in CXXRecord scope to have no access specifier.
      
      Using a BlockDecl in a default member initializer causes it to be attached to
      CXXMethodDecl without its access specifier being set.  This prevents a crash
      where getAccess is called on this BlockDecl, since that method expects any
      Decl in CXXRecord scope to have an access specifier.
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@323108 91177308-0d34-0410-b5e6-96231b3b80d8
      8231d605
  19. Jan 21, 2018
  20. Jan 19, 2018
    • Hans Wennborg's avatar
      Merging r322901: · 9b9bcde7
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r322901 | nico | 2018-01-18 13:40:27 -0800 (Thu, 18 Jan 2018) | 19 lines
      
      Remove TautologicalInRangeCompare from Extra and TautologicalCompare.
      
      This removes the following (already default-off) warnings from -Wextra:
        -Wtautological-type-limit-compare,
        -Wtautological-unsigned-zero-compare
        -Wtautological-unsigned-enum-zero-compare
      
      On the thread "[cfe-dev] -Wtautological-constant-compare issues", clang
      code owners Richard Smith, John McCall, and Reid Kleckner as well as
      libc++ code owner Marshall Clow stated that these new warnings are not
      yet ready for prime time and shouldn't be part of -Wextra.
      
      Furthermore, Vedant Kumar (Apple), Peter Hosek (Fuchsia), and me (Chromium)
      expressed the same concerns (Vedant on that thread, Peter on
      https://reviews.llvm.org/D39462, me on https://reviews.llvm.org/D41512).
      
      So remove them from -Wextra, and remove TautologicalInRangeCompare from
      TautologicalCompare too until they're usable with real-world code.
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@322931 91177308-0d34-0410-b5e6-96231b3b80d8
      9b9bcde7
  21. Jan 17, 2018
    • Hans Wennborg's avatar
      Merging r322246: · 23060de2
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r322246 | ctopper | 2018-01-10 17:38:00 -0800 (Wed, 10 Jan 2018) | 1 line
      
      [X86] Fix vpshrd builtins to require an ICE for their constant argument to match vpshld.
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@322682 91177308-0d34-0410-b5e6-96231b3b80d8
      23060de2
    • Hans Wennborg's avatar
      Merging r321779: · ca189f00
      Hans Wennborg authored
      ------------------------------------------------------------------------
      r321779 | rsmith | 2018-01-03 17:24:17 -0800 (Wed, 03 Jan 2018) | 7 lines
      
      PR35045: Convert injected-class-name to its corresponding simple-template-id
      during template argument deduction.
      
      We already did this when the injected-class-name was in P, but missed the case
      where it was in A. This (probably) can't happen except in implicit deduction
      guides.
      
      ------------------------------------------------------------------------
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@322677 91177308-0d34-0410-b5e6-96231b3b80d8
      ca189f00
Loading