Skip to content
Snippets Groups Projects
  1. Dec 05, 2017
    • Shoaib Meenai's avatar
      [CMake] Use PRIVATE in target_link_libraries for executables · 456e35cb
      Shoaib Meenai authored
      We currently use target_link_libraries without an explicit scope
      specifier (INTERFACE, PRIVATE or PUBLIC) when linking executables.
      Dependencies added in this way apply to both the target and its
      dependencies, i.e. they become part of the executable's link interface
      and are transitive.
      
      Transitive dependencies generally don't make sense for executables,
      since you wouldn't normally be linking against an executable. This also
      causes issues for generating install export files when using
      LLVM_DISTRIBUTION_COMPONENTS. For example, clang has a lot of LLVM
      library dependencies, which are currently added as interface
      dependencies. If clang is in the distribution components but the LLVM
      libraries it depends on aren't (which is a perfectly legitimate use case
      if the LLVM libraries are being built static and there are therefore no
      run-time dependencies on them), CMake will complain about the LLVM
      libraries not being in export set when attempting to generate the
      install export file for clang. This is reasonable behavior on CMake's
      part, and the right thing is for LLVM's build system to explicitly use
      PRIVATE dependencies for executables.
      
      Unfortunately, CMake doesn't allow you to mix and match the keyword and
      non-keyword target_link_libraries signatures for a single target; i.e.,
      if a single call to target_link_libraries for a particular target uses
      one of the INTERFACE, PRIVATE, or PUBLIC keywords, all other calls must
      also be updated to use those keywords. This means we must do this change
      in a single shot. I also fully expect to have missed some instances; I
      tested by enabling all the projects in the monorepo (except dragonegg),
      and configuring both with and without shared libraries, on both Darwin
      and Linux, but I'm planning to rely on the buildbots for other
      configurations (since it should be pretty easy to fix those).
      
      Even after this change, we still have a lot of target_link_libraries
      calls that don't specify a scope keyword, mostly for shared libraries.
      I'm thinking about addressing those in a follow-up, but that's a
      separate change IMO.
      
      Differential Revision: https://reviews.llvm.org/D40823
      
      
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@319840 91177308-0d34-0410-b5e6-96231b3b80d8
      456e35cb
  2. Jan 14, 2017
  3. Jan 06, 2017
  4. Jan 05, 2017
  5. Jan 26, 2016
  6. Oct 03, 2014
  7. Sep 04, 2014
  8. Sep 03, 2014
  9. Aug 19, 2014
  10. Aug 08, 2014
  11. Aug 07, 2014
  12. Jul 24, 2014
  13. Jul 16, 2014
    • Alp Toker's avatar
      Make clang's rewrite engine a core feature · 6c4abb16
      Alp Toker authored
      The rewrite facility's footprint is small so it's not worth going to these
      lengths to support disabling at configure time, particularly since key compiler
      features now depend on it.
      
      Meanwhile the Objective-C rewriters have been moved under the
      ENABLE_CLANG_ARCMT umbrella for now as they're comparatively heavy and still
      potentially worth excluding from lightweight builds.
      
      Tests are now passing with any combination of feature flags. The flags
      historically haven't been tested by LLVM's build servers so caveat emptor.
      
      git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@213171 91177308-0d34-0410-b5e6-96231b3b80d8
      6c4abb16
  14. Jul 15, 2014
  15. Jul 09, 2014
  16. Jul 01, 2014
  17. May 16, 2014
  18. Mar 09, 2014
  19. Dec 10, 2013
  20. Oct 19, 2013
  21. Sep 12, 2013
  22. Jun 26, 2013
  23. Jun 17, 2013
  24. Jun 14, 2013
  25. Mar 26, 2013
  26. Jan 20, 2013
  27. Jan 16, 2013
  28. Jan 12, 2013
  29. Jan 02, 2013
Loading