Use constants for states

lib/Stats/Collector/BaseCollector.php

@@ -11,6 +11,8 @@ use OCP\IDBConnection;
 
 abstract class BaseCollector implements ICollector {
 	const RETRY_TIMES = 3;
+	const STATE_ENABLED = 'true';
+	const STATE_DISABLED = 'false';
 
 	public function collect(IDBConnection $db, int $timestamp, int $chunkSize, ConfigService $config) {
 		$data = null;

lib/Stats/Collector/FileTypesCountsCollector.php

@@ -10,7 +10,7 @@ use OCP\IDBConnection;
 class FileTypesCountsCollector extends BaseCollector {
     protected function collectData(IDBConnection $db, int $timestamp, int $chunkSize, ConfigService $config) {
         $fileCounts = [];
-        $mapper = new FilecacheMapper($db, $chunkSize, $config->getSnapshotFiletypesFilterClosedAccounts() ? '1' : 0);
+        $mapper = new FilecacheMapper($db, $chunkSize, $config->getSnapshotFiletypesFilterClosedAccounts() ? self::STATE_ENABLED : 0);
 	    $counts = $mapper->queryFiletypesCounts();
 	    foreach ($config->getSnapshotFileTypes()->groups() as $groupName => $group) {
 		    if (!$group->isCollectEnabled()) {

lib/Stats/Collector/FilesCountCollector.php

@@ -13,7 +13,7 @@ class FilesCountCollector extends BaseCollector {
     protected function collectData(IDBConnection $db, int $timestamp, int $chunkSize, ConfigService $config) {
         $mapper = new FilecacheMapper($db, $chunkSize);
 		$totalCount = $mapper->queryTotalFilesCount();
-		$mapper->setAccountsState(0); # disabled
+		$mapper->setAccountsState(self::STATE_DISABLED);
 	    $obsoleteCount = $mapper->queryTotalFilesCount();
         return [
 			FilesCountValue::TOTAL_COUNT => $totalCount,

lib/Stats/Collector/FilesSizeCollector.php

@@ -13,7 +13,7 @@ class FilesSizeCollector extends BaseCollector {
     protected function collectData(IDBConnection $db, int $timestamp, int $chunkSize, ConfigService $config) {
         $mapper = new FilecacheMapper($db, $chunkSize);
 	    $totalCount = $mapper->queryTotalFilesSize();
-	    $mapper->setAccountsState(0); #disabled
+	    $mapper->setAccountsState(self::STATE_DISABLED);
 	    $obsoleteCount = $mapper->queryTotalFilesSize();
 	    return [
 		    FilesSizeValue::TOTAL_SIZE => $totalCount,

lib/Stats/Collector/UsersCountCollector.php

@@ -12,8 +12,8 @@ use OCP\IDBConnection;
 class UsersCountCollector extends BaseCollector {
     protected function collectData(IDBConnection $db, int $timestamp, int $chunkSize, ConfigService $config): array {
         $mapper = new PreferencesMapper($db, $chunkSize);
-		$activeUsers = $mapper->queryTotalCount('true');
-		$closedUsers = $mapper->queryTotalCount('false');
+		$activeUsers = $mapper->queryTotalCount(self::STATE_ENABLED);
+		$closedUsers = $mapper->queryTotalCount(self::STATE_DISABLED);
         $values = [UsersCountValue::TOTAL_COUNT => $activeUsers + $closedUsers, UsersCountValue::CLOSED_COUNT => $closedUsers];
         foreach (TimePeriods::periods() as $k => $period) {
             $values[$k] = $mapper->queryActiveCount($period->before($timestamp));