Let -Wdelete-non-virtual-dtor fire in system headers too.
Makes the warning useful again in a std::unique_ptr world, PR28460. Also make the warning not fire in unevaluated contexts, since system libraries (e.g. libc++) do do that. This would've been a good change before we started emitting this warning in system headers too, but "normal" code seems to be less template-heavy, so we didn't notice until now. https://reviews.llvm.org/D37235 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@312167 91177308-0d34-0410-b5e6-96231b3b80d8
Showing
- include/clang/Basic/DiagnosticSemaKinds.td 2 additions, 2 deletionsinclude/clang/Basic/DiagnosticSemaKinds.td
- lib/Sema/SemaExprCXX.cpp 1 addition, 1 deletionlib/Sema/SemaExprCXX.cpp
- test/SemaCXX/destructor.cpp 45 additions, 12 deletionstest/SemaCXX/destructor.cpp
- test/SemaCXX/implicit-exception-spec.cpp 1 addition, 1 deletiontest/SemaCXX/implicit-exception-spec.cpp
Loading
Please register or sign in to comment